Re: [Rosegarden-user] Unwanted CCs - update - !!!AHA!!!

2015-02-10 Thread Abrolag
I just had a nose around in MidiFile.cpp - without full hazmat too :)

At line 1221 you have the start of a section that interprets bank changes. This
is very risky as almost every synth maker has a different way of handling them.

Commenting out both the msb and lsb code appears to cure the problem.

Can someone more knowledgeable have a look and see what other implications there
may be?


-- 
Will J Godfrey
http://www.musically.me.uk
Say you have a poem and I have a tune.
Exchange them and we can both have a poem, a tune, and a song.

--
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
___
Rosegarden-user mailing list
Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-user


Re: [Rosegarden-user] Unwanted CCs - update - !!!AHA!!!

2015-02-10 Thread D. Michael McIntyre
On 02/10/2015 01:46 PM, Abrolag wrote:

 I just had a nose around in MidiFile.cpp - without full hazmat too :)

 At line 1221 you have the start of a section that interprets bank changes. 
 This
 is very risky as almost every synth maker has a different way of handling 
 them.

I was wondering about that, now that you mention it.  Controller banks? 
  Does anything support more than 127 controllers?  Are bank changes 
used for something else?  Was that code meant to tackle a known case?

The answer to all those questions is probably but yet I somehow doubt 
our good-intentioned code even works anyway.

The fastest way to find out whether anybody is using something or not is 
to disable it and wait for the complaints.

H.
-- 
D. Michael McIntyre

--
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
___
Rosegarden-user mailing list
Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-user