Re: [Rosegarden-user] Build oddity

2020-07-31 Thread Ted Felix
Just pushed the fix as [r15896]. Ted. On 7/31/20 1:33 PM, Will Godfrey wrote: Thanks for getting back to me so quickly. NULL gave the same result, but item.reset() worked fine. Sorry I took so long letting you know but my 'office' is right under the roof and it became way too hot to even

Re: [Rosegarden-user] Build oddity

2020-07-31 Thread Will Godfrey
Thanks for getting back to me so quickly. NULL gave the same result, but item.reset() worked fine. Sorry I took so long letting you know but my 'office' is right under the roof and it became way too hot to even walk in the room today :( Will. On Fri, 31 Jul 2020 08:35:24 -0400 Ted Felix wrote:

Re: [Rosegarden-user] Build oddity

2020-07-31 Thread Ted Felix
On 7/31/20 8:35 AM, Ted Felix wrote:   Removing that line will simply leak memory. Actually, it will not leak memory. It appears as if it will always select the last item. Whatever it might do, it's easily fixed with reset(). Ted. ___

Re: [Rosegarden-user] Build oddity

2020-07-31 Thread Ted Felix
The line in question is this: item = nullptr; It's not the compiler, it's the version of Qt you are using. Prior to 5.8, QSharedPointer didn't handle nullptr. Removing that line will simply leak memory. It can be fixed by changing it to NULL, or doing it the shared_ptr way:

[Rosegarden-user] Build oddity

2020-07-31 Thread Will Godfrey
I have two machines, the older one with gcc 6.3.0 and the newer one running gcc 8.3.0. On the newer one rosegarden build 15895 compiles without issues, but on the older one I get a mismatch type failure at: rosegarden-15895/src/gui/rulers/PropertyControlRuler.cpp line 265 If I comment this line