Re: [Rosegarden-user] Add Control Ruler not working as expected in Matrix Editor and a few other questions

2020-07-22 Thread Ted Felix

On 7/22/20 5:56 AM, Hugo van Galen wrote:

Should I [...] add a comment to bug #1543


  I've copied over the fix and added a comment to bug #1543.  Please 
test the latest svn and respond in the bug report with the results.  Thanks.


https://sourceforge.net/p/rosegarden/bugs/1543/

Ted.


___
Rosegarden-user mailing list
Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-user


Re: [Rosegarden-user] Add Control Ruler not working as expected in Matrix Editor and a few other questions

2020-07-22 Thread Ted Felix

On 7/22/20 5:56 AM, Hugo van Galen wrote:

I looked into NotationWidget.cpp to see the following comment and code:

     // FIX #1543: If name happens to come to us with an & included 
somewhere,
     // strip the & so the string will match the one we are comparing 
later on.

     //
     name.replace(QRegExp("&"), "");

I can confirm that adding this code to the MatrixWidget.cpp's 
addControlRuler() fixes the issue.


  Thanks for tracking this down.  I will get it in there right now.

Ted.


___
Rosegarden-user mailing list
Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-user


Re: [Rosegarden-user] Add Control Ruler not working as expected in Matrix Editor and a few other questions

2020-07-22 Thread Hugo van Galen
I replaced the RG_DEBUG with RG_WARNING and now I do see messages :-)

I added some more messages, also around the test if "name" isn't equal to
"itemStr" -- and that reveals clearly what the problem is:

[MatrixWidget] addControlRuler() Mismatched name,  " Controller 7
(0x7)"  not equal to  "Volume Controller 7 (0x7)"

If I remember correctly from my QT coding days, anything with an "&"
(ampersand) before it is shown underlined to indicate the shortcut key in
the menu.

I looked into NotationWidget.cpp to see the following comment and code:

// FIX #1543: If name happens to come to us with an & included
somewhere,
// strip the & so the string will match the one we are comparing later
on.
//
name.replace(QRegExp("&"), "");

I can confirm that adding this code to the MatrixWidget.cpp's
addControlRuler() fixes the issue.

Should I report this as a separate bug, add a comment to bug #1543, or
assume that it will get fixed after a developer has read this message? :)

Best regards,
Hugo

On Tue, 21 Jul 2020 at 14:28, Hugo van Galen  wrote:

> Thanks for your response.
>
> Regarding the controllers not appearing, I today took a look at the
> relevant code. I've fetched the latest code from SVN and I have enabled the
> RG_DEBUG lines in MatrixWidget::addControlRuler(). As I didn't see any of
> those messages, it appears that this method isn't even called. That
> explains why nothing seems to happen. I may try to trace this issue at a
> later time.
>
> I ran into another interesting bug when I restarted Rosegarden. See, one
> of my MIDI outs goes to two different devices, so I had named it "FB-01 &
> P-55". When I started Rosegarden to re-open that document, I got an parsing
> error along the lines of "letter was expected at line X, column Y". I had
> to gunzip the .rg file, modified the XML so it contained "" in stead
> of "&", and gzipped it back up. After that, Rosegarden could successfully
> load it again. (Phew -- I was afraid it somehow got corrupted and I lost my
> song.) I shall submit a bug report for this one, I can imagine that being
> really annoying.
>
> Regards,
> Hugo
>
> On Tue, 30 Jun 2020 at 16:33, Ted Felix  wrote:
>
>> On 6/29/20 4:41 AM, Hugo van Galen wrote:
>> > I have been using Rosegarden for about a decade now and have been able
>> > to figure it out using search engines. Lately I ran into an issue that
>> I
>> > don't remember having before: I noticed that, when in the Matrix
>> Editor,
>> > the option "View / Rulers / Add Control Ruler / Volume Controller"
>> > doesn't do anything; yet when in the "Notation Editor" this works fine.
>>
>>I can't reproduce this.  But the code does look like it needs some
>> review.  The issue will likely become apparent upon cleaning up and
>> syncing the relevant routines.
>>
>> > It seems that any other controller except Velocity and Pitch bend only
>> > work in the Notation Editor.
>>
>>Those are handled separately, so it isn't surprising they are not
>> affected.
>>
>> > Is there an underlying logical reason for
>> > this to behave this way -- or is this a bug?
>>
>>Sounds like you've found a legitimate bug.  The key routines in
>> question are:
>>
>> MatrixWidget::addControlRuler()
>> NotationWidget::slotAddControlRuler()
>>
>>There are differences that need to be resolved between those two and
>> that might clear up the issue.  I don't have time at the moment, but
>> should be back to Rosegarden this weekend.  I will have a look then.
>>
>> > - I also wonder whether it is already possible to "remember" the zoom
>> > options for any given segment as I always find myself tweaking
>> > these, the default zoom doesn't work for me here. Or am I overlooking
>> > something obvious in the settings? (Ideally, it would be great if all
>> > "view" options could be memorised, so when opening the same segment
>> > later, all zoom options, and controller rulers could be restored.)
>>
>>This is very likely an oversight.  I recommend opening a feature
>> request on sourceforge:
>>
>> https://sourceforge.net/p/rosegarden/feature-requests/
>>
>> > - I wonder how the Figuration functionality actually works
>>
>>Not my area of expertise.  Somebody here can probably fill in the
>> blanks, though.  Then we really should update the documentation based on
>> what was found.
>>
>> Ted.
>>
>>
>> ___
>> Rosegarden-user mailing list
>> Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe
>> https://lists.sourceforge.net/lists/listinfo/rosegarden-user
>>
>
___
Rosegarden-user mailing list
Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-user


Re: [Rosegarden-user] Add Control Ruler not working as expected in Matrix Editor and a few other questions

2020-07-21 Thread Hugo van Galen
Thanks for your response.

Regarding the controllers not appearing, I today took a look at the
relevant code. I've fetched the latest code from SVN and I have enabled the
RG_DEBUG lines in MatrixWidget::addControlRuler(). As I didn't see any of
those messages, it appears that this method isn't even called. That
explains why nothing seems to happen. I may try to trace this issue at a
later time.

I ran into another interesting bug when I restarted Rosegarden. See, one of
my MIDI outs goes to two different devices, so I had named it "FB-01 &
P-55". When I started Rosegarden to re-open that document, I got an parsing
error along the lines of "letter was expected at line X, column Y". I had
to gunzip the .rg file, modified the XML so it contained "" in stead
of "&", and gzipped it back up. After that, Rosegarden could successfully
load it again. (Phew -- I was afraid it somehow got corrupted and I lost my
song.) I shall submit a bug report for this one, I can imagine that being
really annoying.

Regards,
Hugo

On Tue, 30 Jun 2020 at 16:33, Ted Felix  wrote:

> On 6/29/20 4:41 AM, Hugo van Galen wrote:
> > I have been using Rosegarden for about a decade now and have been able
> > to figure it out using search engines. Lately I ran into an issue that I
> > don't remember having before: I noticed that, when in the Matrix Editor,
> > the option "View / Rulers / Add Control Ruler / Volume Controller"
> > doesn't do anything; yet when in the "Notation Editor" this works fine.
>
>I can't reproduce this.  But the code does look like it needs some
> review.  The issue will likely become apparent upon cleaning up and
> syncing the relevant routines.
>
> > It seems that any other controller except Velocity and Pitch bend only
> > work in the Notation Editor.
>
>Those are handled separately, so it isn't surprising they are not
> affected.
>
> > Is there an underlying logical reason for
> > this to behave this way -- or is this a bug?
>
>Sounds like you've found a legitimate bug.  The key routines in
> question are:
>
> MatrixWidget::addControlRuler()
> NotationWidget::slotAddControlRuler()
>
>There are differences that need to be resolved between those two and
> that might clear up the issue.  I don't have time at the moment, but
> should be back to Rosegarden this weekend.  I will have a look then.
>
> > - I also wonder whether it is already possible to "remember" the zoom
> > options for any given segment as I always find myself tweaking
> > these, the default zoom doesn't work for me here. Or am I overlooking
> > something obvious in the settings? (Ideally, it would be great if all
> > "view" options could be memorised, so when opening the same segment
> > later, all zoom options, and controller rulers could be restored.)
>
>This is very likely an oversight.  I recommend opening a feature
> request on sourceforge:
>
> https://sourceforge.net/p/rosegarden/feature-requests/
>
> > - I wonder how the Figuration functionality actually works
>
>Not my area of expertise.  Somebody here can probably fill in the
> blanks, though.  Then we really should update the documentation based on
> what was found.
>
> Ted.
>
>
> ___
> Rosegarden-user mailing list
> Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe
> https://lists.sourceforge.net/lists/listinfo/rosegarden-user
>
___
Rosegarden-user mailing list
Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-user


Re: [Rosegarden-user] Add Control Ruler not working as expected in Matrix Editor and a few other questions

2020-06-30 Thread Ted Felix

On 6/29/20 4:41 AM, Hugo van Galen wrote:
I have been using Rosegarden for about a decade now and have been able 
to figure it out using search engines. Lately I ran into an issue that I 
don't remember having before: I noticed that, when in the Matrix Editor, 
the option "View / Rulers / Add Control Ruler / Volume Controller" 
doesn't do anything; yet when in the "Notation Editor" this works fine.


  I can't reproduce this.  But the code does look like it needs some 
review.  The issue will likely become apparent upon cleaning up and 
syncing the relevant routines.


It seems that any other controller except Velocity and Pitch bend only 
work in the Notation Editor.


  Those are handled separately, so it isn't surprising they are not 
affected.


Is there an underlying logical reason for 
this to behave this way -- or is this a bug?


  Sounds like you've found a legitimate bug.  The key routines in 
question are:


MatrixWidget::addControlRuler()
NotationWidget::slotAddControlRuler()

  There are differences that need to be resolved between those two and 
that might clear up the issue.  I don't have time at the moment, but 
should be back to Rosegarden this weekend.  I will have a look then.


- I also wonder whether it is already possible to "remember" the zoom 
options for any given segment as I always find myself tweaking 
these, the default zoom doesn't work for me here. Or am I overlooking 
something obvious in the settings? (Ideally, it would be great if all 
"view" options could be memorised, so when opening the same segment 
later, all zoom options, and controller rulers could be restored.)


  This is very likely an oversight.  I recommend opening a feature 
request on sourceforge:


https://sourceforge.net/p/rosegarden/feature-requests/


- I wonder how the Figuration functionality actually works


  Not my area of expertise.  Somebody here can probably fill in the 
blanks, though.  Then we really should update the documentation based on 
what was found.


Ted.


___
Rosegarden-user mailing list
Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-user