Re: [Rosegarden-user] Minor .rgd inconsistencies with easy fixes

2022-01-13 Thread Ted Felix
  Thanks for the info.  I just pushed a fix for these to master.  I 
left the duplicate Casio file just to be safe.  It's tiny.


Ted.

On 1/12/22 2:06 PM, Kevin Cole wrote:

They say a foolish consistency is the hobgoblin of small minds... I
guess my mind is small. ;-)

I'm using rosegarden  1:19.12-1build1 from the Ubuntu repos.

In poking a stick at the .rgd files that were bundled in the package,
I noticed minor issues. While probably not important, they're all
low-hanging fruit, relatively easy to fix. So, at least for my own
installation I'm going to edit them:

* `HammondSK1.rgd` is not gzip'd.

* `Juno-G.rgd` uses `\240` instead of " "
   (a.k.a. SPACE), leading it to be ID'd as a binary file.

* `Casio-XW-P1.rgd` uses `\222` rather than `` for
   apostrophe, leading it to be ID'd as a binary file.

* Other than the fact that one has apostrophes in attribute
   values and the other does not (e.g. "70's" vs. "70s")
  `Casio-XW-P1.rgd` and `Casio-XWP1.rgd` are basically
   identical. (The other insignificant change is the order of the
   attributes within a tag: One prefers `msb` followed by `lsb` whereas
   the other prefers `lsb` followed by `msb`.) So, one can probably be
   eliminated. (If backwards-compatibility is a concern, a symlink / alias /
   shortcut between the two would take care of the issue.) I'm favoring
   the one with the apostrophes as the "keeper".


___
Rosegarden-user mailing list
Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-user




___
Rosegarden-user mailing list
Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-user


Re: [Rosegarden-user] Minor .rgd inconsistencies with easy fixes

2022-01-12 Thread Ted Felix

On 1/12/22 2:06 PM, Kevin Cole wrote:

* `HammondSK1.rgd` is not gzip'd.


  This was fixed in a later version.  I think I caught it when I was 
fixing all the Expression controller defaults.  Might have been somebody 
else, though.


  Good catch on the others.  I'll add to my todo.

Ted.


___
Rosegarden-user mailing list
Rosegarden-user@lists.sourceforge.net - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-user