Re: [patch] catalina base64, optimizations and code cleanup [offlist]

2002-02-19 Thread Jon Scott Stevens
on 2/19/02 2:12 PM, "John Wilson" <[EMAIL PROTECTED]> wrote: > I seem to have offended Jon - I'm trying, off list, to sort this out. I'm > sorry if I have cause problems - it was not my intention. You have not offended me. -jon

Re: [patch] catalina base64, optimizations and code cleanup [off list]

2002-02-19 Thread John Wilson
Apologies to all - this was intended to be an off list reply. I'm *really* embarrassed to have screwed this up. John Wilson The Wilson Partnership http://www.wilson.co.uk

Re: [patch] catalina base64, optimizations and code cleanup [off list]

2002-02-19 Thread John Wilson
- Original Message - From: "Daniel Rall" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Tuesday, February 19, 2002 9:02 PM Subject: Re: [patch] catalina base64, optimizations and code cleanup > "John Wilson" <[EMAIL PROTECTED]> writes: >

Re: [patch] catalina base64, optimizations and code cleanup

2002-02-19 Thread Daniel Rall
"John Wilson" <[EMAIL PROTECTED]> writes: >> At CollabNet, we aren't passing binary data around over XML-RPC, so >> we won't be hitting that code. > > Yes, but surely Apache XML-RPC is being developed and supported for a wider > audience than CollabNet. Or have I misunderstood something? No, you

Re: [patch] catalina base64, optimizations and code cleanup

2002-02-19 Thread Jon Scott Stevens
on 2/19/02 12:46 PM, "John Wilson" <[EMAIL PROTECTED]> wrote: >> My decision to use Catalina' code is based entirely on the fact that >> Catalina is *by far* the most used piece of software on Jakarta. Something >> like 100-200,000 downloads/week. If the Base64 implementation sucked, it >> would

Re: [patch] catalina base64, optimizations and code cleanup

2002-02-19 Thread John Wilson
- Original Message - From: "Jon Scott Stevens" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Tuesday, February 19, 2002 8:03 PM Subject: Re: [patch] catalina base64, optimizations and code cleanup [snip] > My decision to use Catalina' code is b

Re: [patch] catalina base64, optimizations and code cleanup

2002-02-19 Thread Jon Scott Stevens
on 2/19/02 11:47 AM, "John Wilson" <[EMAIL PROTECTED]> wrote: > Have you done any performance testing on this new code? Historically we had > quite a bit of problems with people reporting very poor performance with > large (multi megabyte) Base64 values (Yes, people do do this sort of thing > wit

Re: [patch] catalina base64, optimizations and code cleanup

2002-02-19 Thread John Wilson
. John Wilson The Wilson Partnership http://www.wilson.co.uk - Original Message - From: "Jon Scott Stevens" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Tuesday, February 19, 2002 1:22 AM Subject: [patch] catalina base64, optimizations and code cleanup > Enclosed

[patch] catalina base64, optimizations and code cleanup

2002-02-18 Thread Jon Scott Stevens
Enclosed is a patch where I did a bunch of code cleanup and minor optimizations, switched to the catalina Base64 (note the one FIXME, if someone has a suggestion for a better way, let me know). There is more to come, but this is a good start... -jon changes.diff Description: Binary data