I know what you're thinking: Here we go again!

But I think we should revisit authentication now that we have abstracted the transport from the XML-RPC client. As I go through implementing (cleanly) my new XmlRpcTransport, I took a look at the authentication piece of DefaultXmlRpcTransport and LiteXmlRpcTransport.

It isn't there!

setBasicAuthentication is still a method of XmlRpcClient. Now, I don't mind leaving it there for the comfort of our users (although I wouldn't mind deprecating it) but I think we should make this functionality a responsibility of the XmlRpcTransport instead. I will go ahead and do this, but not commit it until tomorrow night (after dark EST) so you all get a chance to veto me first :)

--
Ryan Hoegg
ISIS Networks
http://www.isisnetworks.net

Reply via email to