Re: [CVS] RPM: rpm/lib/ fsm.c

2008-12-20 Thread Ralf S. Engelschall
On Sat, Dec 20, 2008, Per Øyvind Karlsen wrote: [...] fsm.c: In function 'fsmMapFContext': fsm.c:772: warning: unused variable 'st' This one? Yes, exactly! I get it on linux as well, but I never figured out why it complained about st being unused since it seemingly did get used two

Re: [CVS] RPM: rpm/lib/ fsm.c

2008-12-20 Thread Per Øyvind Karlsen
2008/12/20 Ralf S. Engelschall rse+rpm-de...@rpm5.orgrse%2brpm-de...@rpm5.org On Sat, Dec 20, 2008, Per Øyvind Karlsen wrote: [...] fsm.c: In function 'fsmMapFContext': fsm.c:772: warning: unused variable 'st' This one? Yes, exactly! I get it on linux as well, but I never

Re: [CVS] RPM: rpm/lib/ fsm.c

2007-07-18 Thread Ralf S. Engelschall
On Wed, Jul 18, 2007, Jeff Johnson wrote: On Jul 18, 2007, at 10:14 AM, Ralf S. Engelschall wrote: On Wed, Jul 18, 2007, Jeff Johnson wrote: Ripping the need for -lpthread is on my todo list. Easier to rip than discuss. Well, a simple --without-pthreads now does the trick just fine and

Re: [CVS] RPM: rpm/lib/ fsm.c

2007-07-18 Thread Ralf S. Engelschall
On Wed, Jul 18, 2007, Jeff Johnson wrote: [...] If I read correctly, the conservative/portable approach is -lpthread in executable so that external libraries linked with -lpthread function correctly. That kinda forces mandatory -lpthread for rpm when external libraries may (or may not) have

Re: [CVS] RPM: rpm/lib/ fsm.c

2007-07-18 Thread Jeff Johnson
On Jul 18, 2007, at 11:11 AM, Ralf S. Engelschall wrote: On Wed, Jul 18, 2007, Jeff Johnson wrote: [...] If I read correctly, the conservative/portable approach is - lpthread in executable so that external libraries linked with -lpthread function correctly. That kinda forces mandatory

Re: [CVS] RPM: rpm/lib/ fsm.c

2007-07-18 Thread Jeff Johnson
On Jul 18, 2007, at 12:39 PM, Ralf S. Engelschall wrote: On Wed, Jul 18, 2007, Jeff Johnson wrote: [...] Or are you planning that RPM can be really internally run multi-threaded? Then the case is different, of course. Then you _have_ to use POSIX pthreads, of course. rpm is already

Re: [CVS] RPM: rpm/lib/ fsm.c

2007-06-19 Thread Ralf S. Engelschall
On Tue, Jun 19, 2007, Jeff Johnson wrote: On Jun 19, 2007, at 2:42 AM, Ralf S. Engelschall wrote: RPM Package Manager, CVS Repository http://rpm5.org/cvs/ Server: rpm5.org Name:

Re: [CVS] RPM: rpm/lib/ fsm.c

2007-06-19 Thread Jeff Johnson
On Jun 19, 2007, at 12:20 PM, Ralf S. Engelschall wrote: On Tue, Jun 19, 2007, Jeff Johnson wrote: Getting mmap enabled is likely a large performance win. Maybe, yes. I've now added the missing Autoconf glue AC_FUNC_MMAP for checking whether the system supports a reasonable mmap(2). Let's