It mostly doesn't matter whether enum's and such are typedef'd or not.
__BUT__
rpmlog is based on syslog(3) and there's really no reason not
to continue exactly that (yes ancient and still widely used) API
in rpm itself.
From man 3 syslog, the 1st arg to syslog(3) is an int, with multiple
2008/11/1 Jeff Johnson [EMAIL PROTECTED]
It mostly doesn't matter whether enum's and such are typedef'd or not.
__BUT__
rpmlog is based on syslog(3) and there's really no reason not
to continue exactly that (yes ancient and still widely used) API
in rpm itself.
From man 3 syslog, the 1st
On Nov 1, 2008, at 4:18 PM, Per Øyvind Karlsen wrote:
I guess you're commenting on the previous commit, and not this one? :)
Likely.
I changed the type since I figured that it made the context and
valid values more clear, while also
nicer for debugging (ie. gdb displaying the enumated
What is wrong with
CPPFLAGS=-DRPM_VENDOR_MANDRIVA
Its insane to have Yet More Ways to configure stuff imho.
73 de Jeff
On Nov 1, 2008, at 6:41 PM, Per Øyvind Karlsen wrote:
RPM Package Manager, CVS Repository
http://rpm5.org/cvs/
2008/11/1 Jeff Johnson [EMAIL PROTECTED]
What is wrong with
CPPFLAGS=-DRPM_VENDOR_MANDRIVA
Its insane to have Yet More Ways to configure stuff imho.
73 de Jeff
It's hidden from regular user who'd like to build rpm himself for that
specific vendor.
Maybe not such an important thing
On Nov 1, 2008, at 7:19 PM, Per Øyvind Karlsen wrote:
2008/11/1 Jeff Johnson [EMAIL PROTECTED]
What is wrong with
CPPFLAGS=-DRPM_VENDOR_MANDRIVA
Its insane to have Yet More Ways to configure stuff imho.
73 de Jeff
It's hidden from regular user who'd like to build rpm himself for
Adding test *.src.rpm packages does add a certain amount of bloat
to the rpm distribution tarball.
An alternative approach would require a reference URI, and
tie make check to wget and network access. Note that
make check already fetches popt-1.14-1.src.rpm, so it
would not be new behavior.
