2009/3/13 Panu Matilainen wrote:
On Wed, 11 Mar 2009, Rakesh Pandit wrote:
[..]
Seems sane to me, just a minor nit:
[pmati...@localhost rpm]$ make -j4 /dev/null
rpminstall.c: In function ‘tryReadHeader’:
rpminstall.c:328: warning: unused variable ‘rc’
Somewhat related thing (not introduced
2009/3/13 Panu Matilainen wrote:
On Fri, 13 Mar 2009, Rakesh Pandit wrote:
[..]
Thanks for review.
Copy-paste elimination always welcome, just some minor issues/suggestions:
- Please keep alloc+free pairs symmetric when possible, eg
rpmcliArgIterHelper() does rpmgiNew() so it should be
Why don't you just use:
%build
%configure --enable-unicode-properties --enable-pcregrep-libz
--enable-pcregrep-libbz2 --disable-pcretest-libreadline
The thing you need to remember about rpm macros is that they're really a cross
between macros and defines. In most caseses they are simply
2009/3/10 Jindrich Novy jn...@redhat.com
On Mon, Mar 09, 2009 at 12:24:17PM +0100, Mark Rosenstand wrote:
RPM won't build against
the xz 4.999.8beta running here. But this was also the case for 4.6.0.
Fixed. The HEAD rpm should build (and work) fine with xz-4.999.8beta.
Jindrich
Yet
