Re: [Rpm-maint] [PATCH] RFC: Add build-id links to rpm for all ELF.

2016-06-06 Thread Mark Wielaard
On Thu, Jun 02, 2016 at 04:35:55PM +0200, Mark Wielaard wrote: > Yeah, I had to move the symlinking code from find-debuginfo.sh (which > uses debugedit to get the build-ids) to the main rpm code since there is > no way for find-debuginfo.sh to add anything to an existing package file > list. And

[Rpm-maint] [PATCH 1/5] Fix indentation and formatting

2016-06-06 Thread Stefan Berger
Fix the indentation and formatting in signature related files. Signed-off-by: Stefan Berger --- lib/rpmsignfiles.c | 12 ++-- sign/rpmgensig.c | 3 ++- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/lib/rpmsignfiles.c b/lib/rpmsignfiles.c

[Rpm-maint] [PATCH 4/4] Add build-id links to rpm for all ELF files.

2016-06-06 Thread Mark Wielaard
This patch moves the main ELF file build-id symlinks from the debuginfo package into the main package. And uses different base directories for the main ELF file build-id symlink. For the main build-id use /usr/lib/.build-id and for the debug build-id use /usr/lib/debug/.build-id. There are two

[Rpm-maint] [PATCH 3/5] Check range of algo index parameter before accessing array with it

2016-06-06 Thread Stefan Berger
Check the range of the algo index parameter before using it for accessing an array. Signed-off-by: Stefan Berger --- lib/rpmsignfiles.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/rpmsignfiles.c b/lib/rpmsignfiles.c index b7d9ccc..97a5be4 100644 ---

Re: [Rpm-maint] [PATCH] Fix array bounds check of decoding[] in base64_decode_value.

2016-06-06 Thread Jonathan Wakely
On 25/05/16 14:32 +0200, Mark Wielaard wrote: This issue was reported against the libb64 public domain code from which rpmio/base64.c was derived. https://sourceforge.net/p/libb64/bugs/2/ The char signedness issue was already solved differently in our code, but the array bounds check was missing

Re: [Rpm-maint] [PATCH] Add find-debuginfo.sh -m minisymtab support.

2016-06-06 Thread Alexander Larsson
On tor, 2016-05-12 at 14:02 +0200, Mark Wielaard wrote: > On Wed, 2016-05-11 at 22:29 +0300, Panu Matilainen wrote: > > > > On 05/11/2016 05:41 PM, Mark Wielaard wrote: > > > > > > The original rpm-4.10.0-minidebuginfo.patch in Fedora was created > > > by > > > Panu Matilainen and Lubos Kardos.

[Rpm-maint] [PATCH 4/5] Extend header size to 64MB due to file signatures

2016-06-06 Thread Stefan Berger
Extend the header size to 64MB in case an RPM has a lot of files and the file signatures do not fit within the current limit of 16MB. An example for an RPM with many files is kcbench-data-4.0. It contains more than 52000 files. With each signature with a 2048 bit key requiring 256 bytes plus a

[Rpm-maint] [PATCH 2/5] Fix various memory leaks in file signature related functions.

2016-06-06 Thread Stefan Berger
Fix various memory leaks in file signature related functions. Signed-off-by: Stefan Berger --- lib/rpmsignfiles.c | 2 ++ rpmsign.c | 4 +++- sign/rpmgensig.c | 24 +--- 3 files changed, 22 insertions(+), 8 deletions(-) diff --git

[Rpm-maint] [PATCH 5/5] Fix handling of zero-length file digests

2016-06-06 Thread Stefan Berger
Do not try to convert a zero-length file digest to a binary representation. Zero-length file digests may stem from directory entries and symbolic links. Return an empty signature in this case. Returning an empty signature results in the ima.so plugin getting a sequence of zeroes that it would

[Rpm-maint] [PATCH 3/4] Add sepdebugcrcfix to fixup old style gnu_debuglink CRC checksum.

2016-06-06 Thread Mark Wielaard
Some old tools might still use the .gnu_debuglink section to find separate debuginfo files instead of build-id style lookups. When dwz has compresses the .debug files the original CRC in the main ELF file will no longer match. Make sure to run sepdebugcrcfix after dwz to recalculate the CRC. The

[Rpm-maint] [PATCH 1/4] Add find-debuginfo.sh -m minisymtab support.

2016-06-06 Thread Mark Wielaard
Support for minisymtab (a minimal function symbol table in a compressed section in the main binary) has been in gdb and elfutils based tools since some years. Fedora has had this as rpm-4.10.0-minidebuginfo.patch since 2012. The patch adjusts macros to pass -m to find-debuginfo.sh when

[Rpm-maint] Some rpm debuginfo improvements

2016-06-06 Thread Mark Wielaard
Hi, As discussed on rpm-ecosystem I am working on some debuginfo improvements. Some improvements have been accepted as new feature for Fedora 25: https://fedoraproject.org/wiki/Changes/ParallelInstallableDebuginfo I am keeping track of all ideas here:

[Rpm-maint] [PATCH 2/4] Add dwz debuginfo compression support.

2016-06-06 Thread Mark Wielaard
Support for dwz compression has been in Fedora since a couple of years. https://fedoraproject.org/wiki/Features/DwarfCompressor The original find-debuginfo.sh patch was written by Jakub Jelinek. https://bugzilla.redhat.com/show_bug.cgi?id=833311 The new testcase using the macros.debug was added

Re: [Rpm-maint] [rpm-software-management/rpm] implement rpmbuild --changelog=FILE support (#69)

2016-06-06 Thread Vít Ondruch
My preferred way would be something like: ``` %changelog %include changelog.txt ``` --- You are receiving this because you commented. Reply to this email directly or view it on GitHub: