On Thu, Jun 02, 2016 at 04:35:55PM +0200, Mark Wielaard wrote:
> Yeah, I had to move the symlinking code from find-debuginfo.sh (which
> uses debugedit to get the build-ids) to the main rpm code since there is
> no way for find-debuginfo.sh to add anything to an existing package file
> list. And
Fix the indentation and formatting in signature related files.
Signed-off-by: Stefan Berger
---
lib/rpmsignfiles.c | 12 ++--
sign/rpmgensig.c | 3 ++-
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/lib/rpmsignfiles.c b/lib/rpmsignfiles.c
This patch moves the main ELF file build-id symlinks from the
debuginfo package into the main package. And uses different
base directories for the main ELF file build-id symlink.
For the main build-id use /usr/lib/.build-id and for the debug
build-id use /usr/lib/debug/.build-id.
There are two
Check the range of the algo index parameter before using it for
accessing an array.
Signed-off-by: Stefan Berger
---
lib/rpmsignfiles.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/lib/rpmsignfiles.c b/lib/rpmsignfiles.c
index b7d9ccc..97a5be4 100644
---
On 25/05/16 14:32 +0200, Mark Wielaard wrote:
This issue was reported against the libb64 public domain code from which
rpmio/base64.c was derived. https://sourceforge.net/p/libb64/bugs/2/
The char signedness issue was already solved differently in our code,
but the array bounds check was missing
On tor, 2016-05-12 at 14:02 +0200, Mark Wielaard wrote:
> On Wed, 2016-05-11 at 22:29 +0300, Panu Matilainen wrote:
> >
> > On 05/11/2016 05:41 PM, Mark Wielaard wrote:
> > >
> > > The original rpm-4.10.0-minidebuginfo.patch in Fedora was created
> > > by
> > > Panu Matilainen and Lubos Kardos.
Extend the header size to 64MB in case an RPM has a lot of files
and the file signatures do not fit within the current limit of 16MB.
An example for an RPM with many files is kcbench-data-4.0. It contains
more than 52000 files. With each signature with a 2048 bit key requiring
256 bytes plus a
Fix various memory leaks in file signature related functions.
Signed-off-by: Stefan Berger
---
lib/rpmsignfiles.c | 2 ++
rpmsign.c | 4 +++-
sign/rpmgensig.c | 24 +---
3 files changed, 22 insertions(+), 8 deletions(-)
diff --git
Do not try to convert a zero-length file digest to a binary representation.
Zero-length file digests may stem from directory entries and symbolic links.
Return an empty signature in this case.
Returning an empty signature results in the ima.so plugin getting a sequence
of zeroes that it would
Some old tools might still use the .gnu_debuglink section to find
separate debuginfo files instead of build-id style lookups. When
dwz has compresses the .debug files the original CRC in the main
ELF file will no longer match. Make sure to run sepdebugcrcfix
after dwz to recalculate the CRC.
The
Support for minisymtab (a minimal function symbol table in a compressed
section in the main binary) has been in gdb and elfutils based tools
since some years. Fedora has had this as rpm-4.10.0-minidebuginfo.patch
since 2012.
The patch adjusts macros to pass -m to find-debuginfo.sh when
Hi,
As discussed on rpm-ecosystem I am working on some debuginfo improvements.
Some improvements have been accepted as new feature for Fedora 25:
https://fedoraproject.org/wiki/Changes/ParallelInstallableDebuginfo
I am keeping track of all ideas here:
Support for dwz compression has been in Fedora since a couple of years.
https://fedoraproject.org/wiki/Features/DwarfCompressor
The original find-debuginfo.sh patch was written by Jakub Jelinek.
https://bugzilla.redhat.com/show_bug.cgi?id=833311
The new testcase using the macros.debug was added
My preferred way would be something like:
```
%changelog
%include changelog.txt
```
---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
14 matches
Mail list logo