Re: [Rpm-maint] [rpm-software-management/rpm] Add support for debugsource subpackages and split debuginfo subpackages (#180)

2017-04-26 Thread ニール・ゴンパ
Conan-Kudo approved this pull request. If it's by design, then it's fine. It works as expected. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for debugsource subpackages and split debuginfo subpackages (#180)

2017-04-26 Thread ニール・ゴンパ
@mlschroe Could you please rebase the PR against the current master so that either @ffesti or @pmatilai can merge it? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for debugsource subpackages and split debuginfo subpackages (#180)

2017-04-26 Thread Michael Schroeder
This is by design. The sources go into the main debuginfo package, all other debuginfo packages get an require to the main one. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for debugsource subpackages and split debuginfo subpackages (#180)

2017-04-26 Thread ニール・ゴンパ
Conan-Kudo requested changes on this pull request. I've tested the following combinations: * debugsource + debuginfo subpackages * debugsource + single debuginfo subpackage * single debuginfo subpackage + no debugsource subpackage * debuginfo subpackages + no debugsource subpackage The first

Re: [Rpm-maint] [rpm-software-management/rpm] kill off deprecated 'mkinstalldirs' (#205)

2017-04-26 Thread ニール・ゴンパ
Apparently, Mac OS X's `mkdir` implementation currently fails the autoconf check, triggering it to fallback to this `mkinstalldirs` implementation. I'm not sure if BSD `install` is an acceptable substitute either. -- You are receiving this because you are subscribed to this thread. Reply to

Re: [Rpm-maint] [rpm-software-management/rpm] dbus_connection_unref(bus) after dbus_connection_close(bus) (#207)

2017-04-26 Thread ニール・ゴンパ
Conan-Kudo approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/207#pullrequestreview-34848934___

Re: [Rpm-maint] [rpm-software-management/rpm] dbus_connection_unref(bus) after dbus_connection_close(bus) (#207)

2017-04-26 Thread proyvind
proyvind commented on this pull request. That oughta suffice, no? :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Incorrect __progname definition (#203)

2017-04-26 Thread Dmitry V. Levin
No, fa06b68 is fine; musl provides __progname, all Yocto needs is just use it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] dbus_connection_unref(bus) after dbus_connection_close(bus) (#207)

2017-04-26 Thread Igor Gnatenko
ignatenkobrain approved this pull request. well, commit is good. we should really unref connection.. but commit message is definitely missing -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: