Re: [Rpm-maint] [rpm-software-management/rpm] Define DistTag as optional tag with macro just like DistURL (from SUSE, used by OMV) (#406)

2018-03-05 Thread ニール・ゴンパ
@ffesti Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/406#issuecomment-370615751___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] rpm ignores architecture when creating self-erasures (#408)

2018-03-05 Thread Jeff Johnson
Apologies for the deleted comment. Meanwhile twisting in concepts of "compatible arch" strings including aliasing in all its flaming glories is going to open a world of buggy painfulness even if narrowly limited to what you are calling "self-updates". The circumstances where a system-wide

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: the macro test-for-existence %{?...} does not scope directly across builtins (#409)

2018-03-05 Thread Jeff Johnson
See usage confusion at #363 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/409#issuecomment-370544954___ Rpm-maint mailing

[Rpm-maint] [rpm-software-management/rpm] RFE: the macro test-for-existence %{?...} does not scope directly across builtins (#409)

2018-03-05 Thread Jeff Johnson
The test should be done earlier against the table of builtins as well as the macro definitions. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Configurable macro file search path(s) (#363)

2018-03-05 Thread Jeff Johnson
Try removing the leading '?', and note that the added documentation explicitly says "file" not pattern. You can verify the load (or attempt) by using "strace -e open" -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Configurable macro file search path(s) (#363)

2018-03-05 Thread Vít Ondruch
Of course, that was just test. So I did different one: ~~~ $ git diff diff --git a/ruby.spec b/ruby.spec index c9ff8dc..ecc5e93 100644 --- a/ruby.spec +++ b/ruby.spec @@ -102,8 +102,7 @@ Source14: test_systemtap.rb # The load directive is supported since RPM 4.12, i.e. F21+. The build process

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Configurable macro file search path(s) (#363)

2018-03-05 Thread ニール・ゴンパ
``` +%{?load:%{_rpmmacrodir}/macros.*} ``` This is redundant... RPM already does this... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Configurable macro file search path(s) (#363)

2018-03-05 Thread Vít Ondruch
This passes: ~~~ $ git diff diff --git a/ruby.spec b/ruby.spec index c9ff8dc..3748781 100644 --- a/ruby.spec +++ b/ruby.spec @@ -104,6 +104,7 @@ Source14: test_systemtap.rb # fails on older Fedoras. %{?load:%{SOURCE4}} %{?load:%{SOURCE5}} +%{?load:%{_rpmmacrodir}/macros.*} # Fix

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Configurable macro file search path(s) (#363)

2018-03-05 Thread Vít Ondruch
Just quick test: ~~~ $ git diff diff --git a/ruby.spec b/ruby.spec index c9ff8dc..fc2e68b 100644 --- a/ruby.spec +++ b/ruby.spec @@ -104,6 +104,7 @@ Source14: test_systemtap.rb # fails on older Fedoras. %{?load:%{SOURCE4}} %{?load:%{SOURCE5}} +%{load:%{_rpmmacrodir}/*} # Fix ruby_version

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Configurable macro file search path(s) (#363)

2018-03-05 Thread Vít Ondruch
Ok, so I can imagine I put this into every SCL meta package, but then I have a few questions. * Does the load macro support the wild cards? * What happens if there is no such macro file? Does it fail or just continue? -- You are receiving this because you are subscribed to this thread. Reply

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Configurable macro file search path(s) (#363)

2018-03-05 Thread ニール・ゴンパ
@voxik No, no no. You can put the macros wherever, just have a `%{load:..}` directive that points to it. If I remember correctly, you can also do something like `%{load:/opt///rpm/macros.d/macros.*}` to load it. However, you have to be careful, since if the macros don't exist, the spec will

Re: [Rpm-maint] [rpm-software-management/rpm] rpmidxGetInternal(): leak on realloc() failure (#357)

2018-03-05 Thread Panu Matilainen
Okay, changed to the x* versions and now redundant error handling removed. Hopefully didn't break anything, but it *seems* really straightforward... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] rpmidxGetInternal(): leak on realloc() failure (#357)

2018-03-05 Thread Panu Matilainen
Closed #357. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/357#event-1504397124___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Configurable macro file search path(s) (#363)

2018-03-05 Thread Vít Ondruch
I am disappointed. Many people calls SCL being big hack, but you won't make it any easier :( So if I read it correctly, the suggestion is that scl-utils should put something into ```%{_rpmmacrodir}``` (please note that the collection itself are generally not allowed to put anything outside

Re: [Rpm-maint] [rpm-software-management/rpm] rpmidxGetInternal(): leak on realloc() failure (#357)

2018-03-05 Thread Michael Schroeder
No, that's fine. We can also remove the code that is not needed in rpm (i.e. the non-rpmxdb code in rpmidx). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] rpmidxGetInternal(): leak on realloc() failure (#357)

2018-03-05 Thread Panu Matilainen
@mlschroe ping, mind if we change ndb to use the rpm "native" xmalloc() etc that never fail? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Configurable macro file search path(s) (#363)

2018-03-05 Thread Panu Matilainen
I guess this was always more a matter of missing documentation than missing feature. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Configurable macro file search path(s) (#363)

2018-03-05 Thread Panu Matilainen
Closed #363. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/363#event-1504309831___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Run binary package generation via thread pools (#226)

2018-03-05 Thread Florian Festi
Ok, I pushed the first and the last patch as a sign of good will. The problem here is that librpm (which rpmstrPool is part of) but also librpmbuild are libraries that might be used in applications running other threading implementations. Also rpm already uses pthread - although not very

[Rpm-maint] [rpm-software-management/rpm] rpm ignores architecture when creating self-erasures (#408)

2018-03-05 Thread Michael Schroeder
This issue once was https://github.com/rpm-software-management/rpm/pull/253 When you have foo-1-1.i586 installed and you do 'rpm -U foo-1-1.i686', rpm will not add an erase element for the i586 package. -- You are receiving this because you are subscribed to this thread. Reply to this email

Re: [Rpm-maint] [rpm-software-management/rpm] Add macros to generate --enable-/disable- arguments (#176)

2018-03-05 Thread Florian Festi
OK, this has not made progress for nearly a year. While there may be some use in further thinking about this the current patch does just not cut it. I am closing this for now. Feel free to continue the discussion on the mailing list or in a new, improved PR. -- You are receiving this because

Re: [Rpm-maint] [rpm-software-management/rpm] Add macros to generate --enable-/disable- arguments (#176)

2018-03-05 Thread Florian Festi
Closed #176. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/176#event-1504075897___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Revert "Revert "Only build bundled fts if system has a bad version th… (#324)

2018-03-05 Thread Panu Matilainen
Half a year later, there's still no fakechroot upstream release with the relevant fix in it. Not exactly a huge surprise since the latest release is from 2016. We can reconsider when they finally cut that release. In the meanwhile, see my earlier comment about nftw()... -- You are receiving

Re: [Rpm-maint] [rpm-software-management/rpm] Also test architecture in "refresh" test when not colored. (#253)

2018-03-05 Thread Florian Festi
Closed #253. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/253#event-1504048274___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Also test architecture in "refresh" test when not colored. (#253)

2018-03-05 Thread Florian Festi
Looks like the patch content and the commit message do not match (or it does not explain things well enough) and there are also some pieces missing. I am closing this for now. Feel free to reopen a PR with a complete set of changes and improved commit messages. -- You are receiving this

Re: [Rpm-maint] [rpm-software-management/rpm] Define DistTag as optional tag with macro just like DistURL (from SUSE, used by OMV) (#406)

2018-03-05 Thread Florian Festi
Closed #406 via 6ba887683b4bf9712be00a3d5dcaa890bfce47c1. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] debugedit: handle RISC-V relocation (#407)

2018-03-05 Thread Florian Festi
Thanks for the patch! Pushed with the surrounding "if defined" guard. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/407#issuecomment-370391017___

Re: [Rpm-maint] [rpm-software-management/rpm] debugedit: handle RISC-V relocation (#407)

2018-03-05 Thread Florian Festi
Closed #407 via 86ec4c03de2b7cc6af6ba5b10dd686002e0b588c. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/407#event-1503893852___ Rpm-maint mailing

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: '!=' vercmp operator (#376)

2018-03-05 Thread Florian Festi
The longer I think about this RFE the more I think it is a bad idea. I am closing this now. Feel free to reopen if there is a good use case and includes a spec file of an existing package. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: '!=' vercmp operator (#376)

2018-03-05 Thread Florian Festi
Closed #376. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/376#event-1503869934___ Rpm-maint mailing list

[Rpm-maint] [PATCH] debugedit: handle RISC-V relocation

2018-03-05 Thread Andreas Schwab
--- tools/debugedit.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools/debugedit.c b/tools/debugedit.c index e0b1d98d99..57cd83030f 100644 --- a/tools/debugedit.c +++ b/tools/debugedit.c @@ -1947,6 +1947,12 @@ edit_dwarf2 (DSO *dso) if (rtype != R_68K_32)

Re: [Rpm-maint] [rpm-software-management/rpm] Define DistTag as optional tag with macro just like DistURL (from SUSE, used by OMV) (#406)

2018-03-05 Thread Michael Schroeder
(Huh, SUSE carries has a patch like that? Weird. We don't use it for sure.) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Rpm-maint] [rpm-software-management/rpm] debugedit: handle RISC-V relocation (#407)

2018-03-05 Thread Andreas Schwab
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/407 -- Commit Summary -- * debugedit: handle RISC-V relocation -- File Changes -- M tools/debugedit.c (4) -- Patch Links --