Re: [Rpm-maint] [rpm-software-management/rpm] fileattrs: Tighten pythondist path regex for metadata (RhBug:1618949) (#562)

2018-10-02 Thread ニール・ゴンパ
@ignatenkobrain Made the requested change. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/562#issuecomment-426472817___

Re: [Rpm-maint] [rpm-software-management/rpm] fileattrs: Tighten pythondist path regex for metadata (RhBug:1618949) (#562)

2018-10-02 Thread Igor Gnatenko
ignatenkobrain commented on this pull request. > @@ -1,3 +1,3 @@ %__pythondist_provides %{_rpmconfigdir}/pythondistdeps.py --provides --majorver-provides %__pythondist_requires %{_rpmconfigdir}/pythondistdeps.py --requires -%__pythondist_path

Re: [Rpm-maint] [rpm-software-management/rpm] fileattrs: Tighten pythondist path regex for metadata (RhBug:1618949) (#562)

2018-10-02 Thread ニール・ゴンパ
Conan-Kudo commented on this pull request. > @@ -1,3 +1,3 @@ %__pythondist_provides %{_rpmconfigdir}/pythondistdeps.py --provides --majorver-provides %__pythondist_requires %{_rpmconfigdir}/pythondistdeps.py --requires -%__pythondist_path

Re: [Rpm-maint] [rpm-software-management/rpm] fileattrs: Tighten pythondist path regex for metadata (RhBug:1618949) (#562)

2018-10-02 Thread ニール・ゴンパ
@keszybz I've made the changes as requested. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/562#issuecomment-426244924___

Re: [Rpm-maint] [rpm-software-management/rpm] Add macro for tar default flags. (#557)

2018-10-02 Thread Andreas Scherer
Don't worry. I'll smash my commits after I'm back at my own machine, where I can actually compile and check this stuff.  -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Add macro for tar default flags. (#557)

2018-10-02 Thread Andreas Scherer
@ascherer pushed 1 commit. 6e2b98a DRY: Uniform error handling. -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: set version to 0 when not present instead of erroring (#559)

2018-10-02 Thread Panu Matilainen
It's not that the software doesn't have *some* version in such a situation, it's just that the long-standing practise is to cram that info into the Release tag which is completely wrong. The right way to deal with such situations is to use the tilde operator, eg ``` Version: 0~git1234" ```

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: set version to 0 when not present instead of erroring (#559)

2018-10-02 Thread Panu Matilainen
Closed #559. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/559#event-1879008589___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Add macro for tar default flags. (#557)

2018-10-02 Thread Andreas Scherer
@ascherer pushed 1 commit. 001509e Quit processing if tar fails. -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: useful lua errors (#545)

2018-10-02 Thread Panu Matilainen
The top macro name you're seeing is simply the line in the spec. Try --trace (or in older versions that don't support it, --eval '%trace') for more advanced macro debugging. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: don't prevealuate lua macros (#556)

2018-10-02 Thread Jeff Johnson
@jasontibbitts: %luamacro would need to be implemented as a co-routine because of rpm's embedded lua interpreter has a persistent global environment. That is very different than shell code, where a sub-shell inherits but cannot change its parent's environment. With rpm+lua, all lua invocations

Re: [Rpm-maint] [rpm-software-management/rpm] Add macro for tar default flags. (#557)

2018-10-02 Thread Andreas Scherer
@ascherer pushed 2 commits. 6036ec0 Source: file extraction may use other filters. 0b4473e Use default option macros for extractors. -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] fileattrs: Tighten pythondist path regex for metadata (RhBug:1618949) (#562)

2018-10-02 Thread Zbigniew Jędrzejewski-Szmek
keszybz requested changes on this pull request. > @@ -1,4 +1,4 @@ %__python_provides %{_rpmconfigdir}/pythondeps.sh --provides %__python_requires %{_rpmconfigdir}/pythondeps.sh --requires -%__python_path