pmatilai commented on this pull request.
> @@ -81,7 +81,7 @@
%__brp_strip %{_rpmconfigdir}/brp-strip %{__strip}
%__brp_strip_comment_note %{_rpmconfigdir}/brp-strip-comment-note %{__strip}
%{__objdump}
%__brp_strip_shared %{_rpmconfigdir}/brp-strip-shared
-%__brp_strip_static_archive
ffesti commented on this pull request.
>
case `uname -a` in
Darwin*) exit 0 ;;
*) ;;
esac
# Strip static libraries.
-for f in `find "$RPM_BUILD_ROOT" -type f -a -exec file {} \; | \
-grep -v "^${RPM_BUILD_ROOT}/\?usr/lib/debug" | \
+for f in `find "$RPM_BUILD_ROOT" -type f | \
ignatenkobrain commented on this pull request.
>
case `uname -a` in
Darwin*) exit 0 ;;
*) ;;
esac
# Strip static libraries.
-for f in `find "$RPM_BUILD_ROOT" -type f -a -exec file {} \; | \
-grep -v "^${RPM_BUILD_ROOT}/\?usr/lib/debug" | \
+for f in `find "$RPM_BUILD_ROOT"
by using xargs -P instead of find -exec
Add xargs to the test environment
Resolves rhbz1691822
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/663
-- Commit Summary --
* Use multiple (%_smp_build_ncpus) processes in
For the record - related changes in redhat-rpm-config
https://src.fedoraproject.org/rpms/redhat-rpm-config/pull-request/51
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@ignatenkobrain The example in
https://fedoraproject.org/wiki/Changes/DynamicBuildRequires?rd=Changes/BuildRequires_Generators#Example
is too complicated. I would suggest to put there some artificial example which
add one artificial dependency and it will use just cat/echo and everything
marxin commented on this pull request.
> @@ -1021,6 +1021,7 @@ package or when debugging this package.\
CFLAGS="${CFLAGS:-%optflags}" ; export CFLAGS ; \
CXXFLAGS="${CXXFLAGS:-%optflags}" ; export CXXFLAGS ; \
FFLAGS="${FFLAGS:-%optflags}" ; export FFLAGS ; \
+
Maybe I didn't say anything about LINE_DEFAULT specifically, just generally
about the 0 enum. The hole and the comment seem just strange now, I'd rather
see that LINE_DEFAULT 0 in the enum even if it's not used at all in the code as
that's along the general style. Nothing forces you to put that
