Closed #703.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/703#event-2356115092___
Rpm-maint mailing list
Closed #491 via aa095c1590517c0ed619f4b072c364f53898860a.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Merged #708 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/708#event-2355899757___
Rpm-maint mailing list
pmatilai commented on this pull request.
> /* Don't expand macros (eg. %define) in false branch of %if clause */
-if (!spec->readStack->reading)
+} else if (!spec->readStack->reading)
return 0;
If one branch of if uses { } blocks, all the branches should have them.
--
pmatilai commented on this pull request.
> @@ -501,17 +506,24 @@ int readLine(rpmSpec spec, int strip)
goto retry;
}
-after_classification:
-if (match != -1) {
+if (lineType->id & (LINE_IF | LINE_IFARCH | LINE_IFNARCH | LINE_IFOS |
+ LINE_IFNOS)) {
This calls
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/710
-- Commit Summary --
* Use already detected line type to identify %if lines
* Consolidate %if condition parsing to one place
* Make "Bad %if condition" error message
Merged #695 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/695#event-2355426236___
Rpm-maint mailing list
Clarified + elaborated the commit messages a bit, hopefully that's better now.
No other changes there.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
