But shouldn't that be `%{?build_ldflags}` as the ldflags line is commented out?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
pmatilai commented on this pull request.
> @@ -130,8 +130,7 @@ static int dateToTimet(const char * datestr, time_t *
> secs, int * date_words)
SKIPNONSPACE(pe);
if (*pe != '\0')
*pe++ = '\0';
- if (((int)(pe-p) + 1) > 9 )
- goto exit;
+ tz_name =
pmatilai commented on this pull request.
> @@ -130,8 +130,7 @@ static int dateToTimet(const char * datestr, time_t *
> secs, int * date_words)
SKIPNONSPACE(pe);
if (*pe != '\0')
*pe++ = '\0';
- if (((int)(pe-p) + 1) > 9 )
- goto exit;
+ tz_name =
pmatilai commented on this pull request.
> @@ -185,6 +184,8 @@ static int dateToTimet(const char * datestr, time_t *
> secs, int * date_words)
rc = 0;
exit:
+if (tz_name)
Don't bother testing for NULL, free() does it anyway so it ends up being just
useless clutter.
--
You are
pavlinamv commented on this pull request.
> @@ -30,10 +30,12 @@ static int sameDate(const struct tm *ot, const struct tm
> *nt)
ot->tm_wday == nt->tm_wday);
}
+#define TZ_MAX_LENGTH 80
Thank you. In the new version dynamic allocation is used.
--
You are receiving this because
pmatilai commented on this pull request.
> @@ -30,10 +30,12 @@ static int sameDate(const struct tm *ot, const struct tm
> *nt)
ot->tm_wday == nt->tm_wday);
}
+#define TZ_MAX_LENGTH 80
Just use dynamic allocation to avoid arbitrary limits that need explanations :)
--
You are
