Re: [Rpm-maint] [rpm-software-management/rpm] Fix segfault regression on empty script or description at end of spec (#816)

The alignment of the commit message is broken otherwise the patch looks perfect. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Add %{expr:...} macro for parsing expressions (#817)

Functionality is OK, but error messages can be improved. I tried macros: %{expr:0 || b} %{expr:4 &|| 0} %{expr:6 + 9 - o -=iu} in a spec file and error messages were: error: types must match error: syntax error while parsing && error: types must match -- You are receiving this because

Re: [Rpm-maint] [rpm-software-management/rpm] Restore strict order of build scriptlet stdout/stderr output (#794) (#818)

I don't know how to reproduce the rust stuff, but I can confirm %prep failing does stop the build still. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Fix segfault regression on empty script or description at end of spec (#816)

I don't know how to reproduce the rust stuff, but %prep failing does stop the build. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Fix segfault regression on empty script or description at end of spec (#816)

Didn't mention it originally because it's not a single commit and easily found by the "parseLines" reference, but commit range added now. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Restore strict order of build scriptlet stdout/stderr output (#794) (#818)

@pmatilai can you check if https://github.com/rpm-software-management/rpm/issues/728 is not broken with this patch? if not, I think it looks good. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Fix segfault regression on empty script or description at end of spec (#816)

The patch is correct. The only thing that I propose to change is to is to refer to the particular commit behind the regression. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Restore strict order of build scriptlet stdout/stderr output (#794) (#818)

Indeed this makes the problem away. I am not qualified enough to verify whether it is good approach or whether t breaks different use cases, but it fixes https://github.com/rpm-software-management/rpm/issues/794 Thank You. -- You are receiving this because you are subscribed to this thread.

Re: [Rpm-maint] [rpm-software-management/rpm] Restore strict order of build scriptlet stdout/stderr output (#794) (#818)

Let there be Fedora rawhide scratchbuild with this patch applied: https://koji.fedoraproject.org/koji/taskinfo?taskID=37069113 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] rpmbuild output is garbled (#794)

This should be fixed by PR #818. If you can test, that'd be awesome. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: