Re: [Rpm-maint] [rpm-software-management/rpm] Tags as an alternative to Groups (#632)

2019-09-03 Thread jengelh
>nobody has stepped up to work out the finer details like a format that is >actually enforced That runs risk of designing something that may turn out bad in 2 years, and then we're stuck with it and go define _another_ field. The freedom of the Group field does not appear to have been a bad

Re: [Rpm-maint] [rpm-software-management/rpm] Rip the marker support for multiline %{expr:...} error messages (#828)

2019-09-03 Thread pavlinamv
Corrected -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/828#issuecomment-527410044___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Rip the marker support for multiline %{expr:...} error messages (#828)

2019-09-03 Thread pavlinamv
@pavlinamv pushed 1 commit. b2260fbae4087f55615219376906d066db7341ee Disable marker on multiline expression error messages -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Rip the marker support for multiline %{expr:...} error messages (#828)

2019-09-03 Thread Panu Matilainen
Really bothers you, huh? These are more on the cosmetic side, but nevertheless: - Use existing string functions (strchr() and friends) instead of manual loops when possible - Use short variable names for temporary local strings, such as "s" which is used all over rpm codebase for such purposes.

[Rpm-maint] [rpm-software-management/rpm] Rip the marker support for multiline %{expr:...} error messages (#828)

2019-09-03 Thread pavlinamv
If the expression after %{expr: is mutiline like: %{expr: 0 || 0 || 0 || 0 |o| 0 || 0 || 0 || 0 } then it is better not to support marker pointing to the exact place of the error. You can view, comment on, or merge this pull request online at: