Re: [Rpm-maint] [rpm-software-management/rpm] Support libgrypt as crypto library (#826)

2019-09-10 Thread Panu Matilainen
I'm quite aware of what a PITA NSS is, been all along (took years to really tame it for rpm). But it also has FIPS mode and the like which are important to some, and despite all the pain it actually *is* actively maintained upstream. So no matter how much I hate it, I don't see it being the

Re: [Rpm-maint] [rpm-software-management/rpm] Suppress inhibition lock warning message in single-user mode (#831)

2019-09-10 Thread Panu Matilainen
Well, under systemd single-user mode is just a name of a target and nothing special in itself. I suppose the right thing would be figuring out not whether dbus is running or not currently, but whether it *should* be running or not. If it's not even supposed to be running in the current target

[Rpm-maint] [rpm-software-management/rpm] Do not allow to divide by 0 in the expression evaluation (#833)

2019-09-10 Thread pavlinamv
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/833 -- Commit Summary -- * Do not allow to divide by 0 in the expression evaluation -- File Changes -- M rpmio/expression.c (4) M tests/rpmmacro.at (2) -- Patch

Re: [Rpm-maint] [rpm-software-management/rpm] Change the default crypto implementation to libgcrypt (from NSS) (#832)

2019-09-10 Thread ニール・ゴンパ
Conan-Kudo approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/832#pullrequestreview-286093620___

Re: [Rpm-maint] [rpm-software-management/rpm] Support libgrypt as crypto library (#826)

2019-09-10 Thread ニール・ゴンパ
@pmatilai The main reason I suggest removing NSS is because NSS has become increasingly troublesome to use for anything except Firefox, and nowadays, NSS upgrades often require rebuilding everything dependent on NSS to continue working properly. We've had incidents where rpm was broken because

Re: [Rpm-maint] [rpm-software-management/rpm] Change the default crypto implementation to libgcrypt (from NSS) (#832)

2019-09-10 Thread Panu Matilainen
@pmatilai pushed 1 commit. 68460c28115934aa8927be807c8cd9fba2496554 Change the default crypto implementation to libgcrypt (from NSS) -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Improve description of conditionals + comments in spec documentation (#830)

2019-09-10 Thread Panu Matilainen
Works for me. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/830#issuecomment-529891374___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Improve description of conditionals + comments in spec documentation (#830)

2019-09-10 Thread Panu Matilainen
Merged #830 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/830#event-2621887065___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Improve description of conditionals + comments in spec documentation (#830)

2019-09-10 Thread pavlinamv
The comments are incorporated in the new version. Thank you for the review. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Improve description of conditionals + comments in spec documentation (#830)

2019-09-10 Thread pavlinamv
@pavlinamv pushed 2 commits. db00406d78149cfaa0e78fea9426d5642bc6a95e Improve description of conditionals in spec documentation c150103aae26475d92ee26d6427a13f9f21890ad Add description of comments in spec documentation -- You are receiving this because you are subscribed to this thread.

Re: [Rpm-maint] [rpm-software-management/rpm] Cannot leave comments after %endif (#829)

2019-09-10 Thread pavlinamv
> The constructive solution to the problem would be supporting spec #-comments > at arbitrary positions, just like the shell does. Supporting spec #-comments at arbitrary positions can potentially cause some problems. That is why I looked into spec files and search for occurrences of #. There

Re: [Rpm-maint] [rpm-software-management/rpm] Suppress inhibition lock warning message in single-user mode (#831)

2019-09-10 Thread shogo-matsumoto
Thank you for your comment. As you pointed out the condition is not equivalent to single-user mode. I only check the error code to judge dbus service (or /var/run/dbus/system_bus_socket) exists, because I thought it seems excessive to check whether the system is in single-user mode by, for

Re: [Rpm-maint] [rpm-software-management/rpm] Support libgrypt as crypto library (#826)

2019-09-10 Thread Panu Matilainen
Default change submitted as PR #832 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/826#issuecomment-529826919___ Rpm-maint

[Rpm-maint] [rpm-software-management/rpm] Change the default crypto implementation to libgcrypt (from NSS) (#832)

2019-09-10 Thread Panu Matilainen
libgcrypt is a much more straightforward and lightweight as a library, doesnt come with a massive runtime library of its own, runtime which messes with SIGPIPE and all, has a nice clearly compatible license (LGPL) and is somewhat faster than NSS. Whats not to like? Change the default and add

Re: [Rpm-maint] [rpm-software-management/rpm] Support libgrypt as crypto library (#826)

2019-09-10 Thread Panu Matilainen
Merged #826 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/826#event-2621108084___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Support libgrypt as crypto library (#826)

2019-09-10 Thread Panu Matilainen
Oh and thanks @mlschroe , this was a very welcome addition. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Support libgrypt as crypto library (#826)

2019-09-10 Thread Panu Matilainen
Anyway... guess @mlschroe is busy, so lets get this merged and I'll do a separate PR for changing the default when I get around to it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Support libgrypt as crypto library (#826)

2019-09-10 Thread Panu Matilainen
Ripping out is a bit radical at this point, I'd start by changing the default. We do need to think about removing too, while the crypto situation warrants *some* choice, I don't believe in choice for choice's sake, and even less so when I'm the one who gets to maintain them all. Also I