Conan-Kudo approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/849#pullrequestreview-291318802___
@pmatilai I'd think this does belong in rpm-4.15 too...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@vathpela pushed 1 commit.
3046bf9b66f8098bacc48be7fe141b91aea87410 Add all of the rpmbuild macro aliases
to rpmspec as well
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
vathpela commented on this pull request.
> @@ -221,8 +221,8 @@ rpmbuild alias --buildpolicy --define '__os_install_post
> %{_rpmconfigdir}/brp-!#
rpmbuild alias --sign \
--pipe 'rpm --addsign `grep ".*: .*\.rpm$"|cut -d: -f2` < "/dev/"`ps -p
$$ -o tty | tail -n 1`' \
Ah, I get what you mean. I think we should print a bare word error if the
expanded string does not start with a digit. This makes it similar to what
`%{expr:...}` and `%if` does:
```
$ ./rpm --define "aaa a" --define "bbb 123b" --eval '%{expr: %aaa }'
error: bare words are no longer supported,
Not sure that message makes it any clearer, I probably failed to explain why I
find it confusing to begin with. I guess the problem is that it doesn't explain
*why* it expects an integer there, and that makes it sound like it will *only*
accept a number there, which in a macro context seems
Thanks for the report, but rpm 4.11 is long since unmaintained upstream ->
wontfix.
In current upstream version, those copying errors are intentionally ignored
because rpm now checks for the file presence separately (see commit
1ba05a7456aafb52e89df5dd42d494d09f9ea6a4), but 4.11.x cannot do so
Closed #808.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/808#event-2650199517___
Rpm-maint mailing list
Thanks for the report. Fix proposed in PR #849
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/807#issuecomment-533535520___
Fixes regression from commit 1ba05a7456aafb52e89df5dd42d494d09f9ea6a4
where doc files always terminate build regardless of the macro value.
Add a testcase to go.
Fixes #807
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/849
Sorry, I haven't commented because I don't really have much insight to this
thing.
What I do know is that originally that the build, host and target stuff was
originally supposed to reflect autoconf's cross-compilation switches by the
same names [1], but either it was woefully misunderstood by
Sorry for the multiple force pushes, I had a little fight with git.
I now use "macro expansion did not return a number" as error message.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@mlschroe pushed 1 commit.
52bd4a99ca452a974b248cf9291454e992e263b3 Implement short-circuit for logical
and ternary operators
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
Yeah, looks that little bit nicer that way, thanks. I don't particularly love
camelCase but when everything in the surroundings uses it...
There's an unrelated indentation change for the division-by-zero case, and
trailing whitespace after the doExpressionExpansion() function. I could live
Merged #847 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/847#event-2649806281___
Rpm-maint mailing list
I switched the helper function to camelCase and moved the digit check into a
separate function to make the code easier to read.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@mlschroe pushed 2 commits.
713d13cb402a76f58be3513fdd8e197754390265 Add support for primary expansion to
the expression parser
11e11cf1fc187efc50e4cdff1036355032f97be3 Implement short-circuit for logical
and ternary operators
--
You are receiving this because you are subscribed to this
Merged #837 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/837#event-2649526462___
Rpm-maint mailing list
Thanks.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/837#issuecomment-533460271___
Rpm-maint mailing list
There might well be a case behind this, but not in this form. Lets close this
and continue elsewhere.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Closed #722.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/722#event-2649523748___
Rpm-maint mailing list
@ffesti, ping? This seems a bit forgotten...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/762#issuecomment-533459277___
Refactored into two commits to eliminate the indentation problem in the first
version, and clarified commit message.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
> Evidently better way is to emit an error.
No kidding? :joy:
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@pavlinamv pushed 1 commit.
e9d4397003b99f0636bbaabb6a9b151145680a1e Add 'string' into query format
extensions in man-pages
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
Added the rdToken() checks + the generic syntax error. Inconsistent error is
much better than no error message at all...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
pmatilai requested changes on this pull request.
See above.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Ehm. I'm not arguing *against* this addition. I just ask that while we're at
it, you *also* document that it's the default format! A simple "(default)"
would do. I sure don't want to do *another* pull request just to add that!
--
You are receiving this because you are subscribed to this
Mentioning ":string" in that part of man page, will not cause any problems. But
if ":string" is not there, it looks like that it is not supported.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@pmatilai pushed 2 commits.
fa72dae56e925a40df1c9d9a5be67c37bc34e10b Always check for rdToken() return
codes in expression parsing
be0700f3dfdb215a171a89d7304d6c0c174f3556 Ensure expression syntax errors get
at least a generic error message
--
You are receiving this because you are
pmatilai commented on this pull request.
> @@ -221,8 +221,8 @@ rpmbuild alias --buildpolicy --define '__os_install_post
> %{_rpmconfigdir}/brp-!#
rpmbuild alias --sign \
--pipe 'rpm --addsign `grep ".*: .*\.rpm$"|cut -d: -f2` < "/dev/"`ps -p
$$ -o tty | tail -n 1`' \
31 matches
Mail list logo
