Re: [Rpm-maint] RPM 4.18.0: Build errors

2022-10-04 Thread Panu Matilainen
On 10/4/22 16:56, Scott Andrews wrote: On Tue, 4 Oct 2022 10:43:28 +0300 Panu Matilainen wrote: On 10/3/22 17:10, Scott Andrews wrote: On Mon, 3 Oct 2022 15:35:24 +0300 Panu Matilainen wrote: On 9/21/22 19:48, Scott Andrews wrote: %prep %setup -q -n %{name}-%{version}-release sed

Re: [Rpm-maint] [rpm-software-management/rpm] unreproducible `rpmdb.sqlite-shm` (Issue #2219)

2022-10-04 Thread Panu Matilainen
The existence of .sqlite-shm is required for read-only WAL mode to work at all (a very important use-case being queries by regular users), see https://www.sqlite.org/wal.html#read_only_database -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Add manual page for File Mode (PR #2215)

2022-10-04 Thread Michal Domonkos
@dmnks pushed 1 commit. 56fa7892459e1e3b1be035b6c6217884a7841a83 Add manual page for RPMIO mode -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2215/files/63a08301708d971a11bd6bd59e2280516c9b9fd8..56fa7892459e1e3b1be035b6c6217884a7841a83 You are receiving this because

Re: [Rpm-maint] [rpm-software-management/rpm] Add manual page for File Mode (PR #2215)

2022-10-04 Thread Michal Domonkos
@dmnks pushed 1 commit. 63a08301708d971a11bd6bd59e2280516c9b9fd8 Add manual page for RPMIO mode -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2215/files/c3d003d4b4cbe0835de1fe6fa39652ec9e7b4f03..63a08301708d971a11bd6bd59e2280516c9b9fd8 You are receiving this because

Re: [Rpm-maint] [rpm-software-management/rpm] Add manual page for File Mode (PR #2215)

2022-10-04 Thread Michal Domonkos
@dmnks pushed 1 commit. c3d003d4b4cbe0835de1fe6fa39652ec9e7b4f03 Add manual page for RPMIO mode -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2215/files/db37db0901545e8ec7826e221e3565b1e9d48263..c3d003d4b4cbe0835de1fe6fa39652ec9e7b4f03 You are receiving this because

Re: [Rpm-maint] [rpm-software-management/rpm] Add manual page for File Mode (PR #2215)

2022-10-04 Thread Michal Domonkos
In the meantime, I pushed a version named "RPMIO Mode", with an added entry to the Plugin subsection in the manual index, and the above comments implemented. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2215#issuecomment-1267217914

Re: [Rpm-maint] [rpm-software-management/rpm] Add manual page for File Mode (PR #2215)

2022-10-04 Thread Michal Domonkos
@dmnks pushed 1 commit. db37db0901545e8ec7826e221e3565b1e9d48263 Add manual page for RPMIO Mode -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2215/files/7bd736b8e413c9de55fb3af9b154062b8bda1f8d..db37db0901545e8ec7826e221e3565b1e9d48263 You are receiving this because

Re: [Rpm-maint] [rpm-software-management/rpm] Add manual page for File Mode (PR #2215)

2022-10-04 Thread Michal Domonkos
@dmnks pushed 1 commit. 7bd736b8e413c9de55fb3af9b154062b8bda1f8d Add manual page for RPMIO Mode -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2215/files/10ea955dbc89bb0e3cf0237f1dcd2a8cb5a04035..7bd736b8e413c9de55fb3af9b154062b8bda1f8d You are receiving this because

Re: [Rpm-maint] [rpm-software-management/rpm] Add manual page for File Mode (PR #2215)

2022-10-04 Thread Michal Domonkos
@dmnks pushed 1 commit. 10ea955dbc89bb0e3cf0237f1dcd2a8cb5a04035 Add manual page for RPMIO Mode -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2215/files/7cd0f365414fcfb05405be8166376e1ffea12912..10ea955dbc89bb0e3cf0237f1dcd2a8cb5a04035 You are receiving this because

Re: [Rpm-maint] [rpm-software-management/rpm] Add manual page for File Mode (PR #2215)

2022-10-04 Thread Michal Domonkos
@dmnks pushed 1 commit. 7cd0f365414fcfb05405be8166376e1ffea12912 Add manual page for RPMIO Mode -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2215/files/e434267dea22c53df35c21962e04354a30b159c4..7cd0f365414fcfb05405be8166376e1ffea12912 You are receiving this because

[Rpm-maint] [rpm-software-management/rpm] unreproducible `rpmdb.sqlite-shm` (Issue #2219)

2022-10-04 Thread Colin Walters
This is a followup to https://github.com/rpm-software-management/rpm/commit/71456f2fc09900a027a33dc3d6d75c69a9b39488 which is about generating bit-for-bit reproducible images (container/disk) that include an RPM database. At the time, the person working on that PR was looking at RHEL8 (BDB

Re: [Rpm-maint] RPM 4.18.0: Build errors

2022-10-04 Thread Scott Andrews
On Tue, 4 Oct 2022 10:43:28 +0300 Panu Matilainen wrote: > On 10/3/22 17:10, Scott Andrews wrote: > > On Mon, 3 Oct 2022 15:35:24 +0300 > > Panu Matilainen wrote: > > > >> On 9/21/22 19:48, Scott Andrews wrote: > >>> %prep > >>> %setup -q -n %{name}-%{version}-release > >>> sed

Re: [Rpm-maint] [rpm-software-management/rpm] Enable malloc checking with random perturb in the test-suite (PR #2218)

2022-10-04 Thread Panu Matilainen
OTOH I kinda wonder whether this should be done in the CI build instead. Wiring these sort of things into the default build tends to bite back at some point. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2218#issuecomment-1266943826

Re: [Rpm-maint] [rpm-software-management/rpm] Add MALLOC_CHECK_ and MALLOC_PERTURB_ libc env to the test suite … (PR #1936)

2022-10-04 Thread Panu Matilainen
Superceded by #2218, but thanks for the initiative and the patch! -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1936#issuecomment-1266921191 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Add MALLOC_CHECK_ and MALLOC_PERTURB_ libc env to the test suite … (PR #1936)

2022-10-04 Thread Panu Matilainen
Closed #1936. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1936#event-7516024869 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list

[Rpm-maint] [rpm-software-management/rpm] Enable malloc checking with random perturb in the test-suite (PR #2218)

2022-10-04 Thread Panu Matilainen
Glibc provides low-cost memory sanity checking on its own, itd be foolish not to take advantage of this in the test-suite for our CI. As this introduces a level of randomness to the system, record the environment in a file (in particular, glibc.malloc.perturb value) to make possible failures

Re: [Rpm-maint] RPM 4.18.0: Build errors

2022-10-04 Thread Scott Andrews
On Tue, 4 Oct 2022 10:43:28 +0300 Panu Matilainen wrote: > On 10/3/22 17:10, Scott Andrews wrote: > > On Mon, 3 Oct 2022 15:35:24 +0300 > > Panu Matilainen wrote: > > > >> On 9/21/22 19:48, Scott Andrews wrote: > >>> %prep > >>> %setup -q -n %{name}-%{version}-release > >>> sed

Re: [Rpm-maint] [rpm-software-management/rpm] Add proper quotation support to %files (PR #2206)

2022-10-04 Thread Michal Domonkos
@dmnks commented on this pull request. > t = NULL; + end = s + strlen(s) - 1; + + /* Syntax checks */ + if (quotes == 1) { + rpmlog(RPMLOG_ERR, _("Missing quote: %s\n"), s); Yup, a line number would be useful of course, but let's leave that for another time.

Re: [Rpm-maint] [rpm-software-management/rpm] Obsolete and conflicts same package (Issue #2217)

2022-10-04 Thread Hasan
@pmatilai Thanks for response. in this situation i don't even need conflicts directive for package if i am going to obsolete and provide mariadb-connector-c. correct? -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Obsolete and conflicts same package (Issue #2217)

2022-10-04 Thread Panu Matilainen
Obsoletes and conflicts are not interchangeable, they serve very different purposes. Obsoletes X means this package replaces X from here to eternity and generally must not be used if X continues to exist. Conflicts merely prevent parallel installation. -- Reply to this email directly or view

[Rpm-maint] [rpm-software-management/rpm] Obsolete and conflicts same package (Issue #2217)

2022-10-04 Thread Hasan
How to correctly use obsolete and conflict interchangeably. For example ``` %package libs Summary: The shared library Conflicts: mariadb-connector-c-config Conflicts: mariadb-connector-c %package -n meta Summary: meta package Requires: %{name}-libs Provides: mariadb-connector-c = 3.2.8-1

Re: [Rpm-maint] RPM 4.18.0: Build errors

2022-10-04 Thread Panu Matilainen
On 10/3/22 17:10, Scott Andrews wrote: On Mon, 3 Oct 2022 15:35:24 +0300 Panu Matilainen wrote: On 9/21/22 19:48, Scott Andrews wrote: %prep %setup -q -n %{name}-%{version}-release sed 's:/bin/sh:/usr/bin/sh:' -i macros.in sh autogen.sh --noconfigure %build _options=( --prefix=/usr

Re: [Rpm-maint] [rpm-software-management/rpm] How can I find details on the binary representation of the RPM DB? (Discussion #2211)

2022-10-04 Thread Panu Matilainen
Nothing wrong with curiosity, and this being open source, obviously nobody can prevent people from looking. However I have no incentive to help planned misuse, which is clearly the case here. The rpmdb format is undocumented because it is a private implementation detail which rpm is free to

Re: [Rpm-maint] [rpm-software-management/rpm] Add manual page for File Mode (PR #2215)

2022-10-04 Thread Michal Domonkos
@dmnks commented on this pull request. > +### Example Modes + +These are some example mode strings suitable for the payload: + +| Mode | Description | +|---|---| +|`w9.gzdio`| gzip level 9, RPM

Re: [Rpm-maint] [rpm-software-management/rpm] Add manual page for File Mode (PR #2215)

2022-10-04 Thread Michal Domonkos
@dmnks commented on this pull request. > +### Example Modes + +These are some example mode strings suitable for the payload: + +| Mode | Description | +|---|---| +|`w9.gzdio`| gzip level 9, RPM

Re: [Rpm-maint] [rpm-software-management/rpm] Add manual page for File Mode (PR #2215)

2022-10-04 Thread Michal Domonkos
@dmnks commented on this pull request. > + +These can include a compression level (from 0 to 9) and a strategy (e.g. `h` +for Huffman-only compression). See the description of `gzopen()` in +`/usr/include/zlib.h` for more details. + + BZIP2 Flags + +These can include a compression level

Re: [Rpm-maint] [rpm-software-management/rpm] Add manual page for File Mode (PR #2215)

2022-10-04 Thread Michal Domonkos
@dmnks commented on this pull request. > @@ -0,0 +1,95 @@ +--- +layout: default +title: rpm.org - File Mode +--- +# File Mode + +RPM supports a variety of compression methods through external libraries for +its internal I/O operations. For ease of use, the [RPMIO

Re: [Rpm-maint] [rpm-software-management/rpm] Add manual page for File Mode (PR #2215)

2022-10-04 Thread Michal Domonkos
@dmnks commented on this pull request. > + +``` +[flags]. +``` + +The `mode` parameter is mandatory and contains a sequence of letters as +described in `fopen(3)`. For payload configuration, only `w` is allowed. + +The `type` parameter is also mandatory and specifies the compression type

Re: [Rpm-maint] [rpm-software-management/rpm] Add manual page for File Mode (PR #2215)

2022-10-04 Thread Michal Domonkos
> On a more general note: "file mode" makes me think of something in the %files > list / chmod. This is only "mode" in the rpmio API, on the macro side it's > just known as payload compression, so maybe call the file "payload", with the > only subsection (for now) being this, ie the

Re: [Rpm-maint] [rpm-software-management/rpm] paths[with spaces and square brackets] cannot be listed in %files (#1749)

2022-10-04 Thread Panu Matilainen
Closed #1749 as completed via #2206. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1749#event-7513431543 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [Rpm-maint] [rpm-software-management/rpm] Add proper quotation support to %files (PR #2206)

2022-10-04 Thread Panu Matilainen
Merged #2206 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2206#event-7513431393 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Add tests for 2038 readiness (PR #1940)

2022-10-04 Thread Panu Matilainen
Closed #1940. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1940#event-7513427900 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Add tests for 2038 readiness (PR #1940)

2022-10-04 Thread Panu Matilainen
This is not in mergeable shape, and there's been no activity in over half a year. No point having this linger on in the list of open PRs, just reopen once the issues have been addressed. -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Add proper quotation support to %files (PR #2206)

2022-10-04 Thread Panu Matilainen
@pmatilai approved this pull request. While I'm not going to claim I understood and carefully considered each and every nuance here, reading through the patch series convinces me that *somebody* did all that consideration :smile: Looks fine to me :+1: -- Reply to this email directly or

Re: [Rpm-maint] [rpm-software-management/rpm] Add proper quotation support to %files (PR #2206)

2022-10-04 Thread Panu Matilainen
@pmatilai commented on this pull request. > t = NULL; + end = s + strlen(s) - 1; + + /* Syntax checks */ + if (quotes == 1) { + rpmlog(RPMLOG_ERR, _("Missing quote: %s\n"), s); I was about to say this should report a line number, but the existing error

Re: [Rpm-maint] [rpm-software-management/rpm] Add manual page for File Mode (PR #2215)

2022-10-04 Thread Panu Matilainen
On a more general note: "file mode" makes me think of something in the %files list / chmod. This is only "mode" in the rpmio API, on the macro side it's just known as payload compression, so maybe call the file "payload", with the only subsection (for now) being this, ie the compression?

Re: [Rpm-maint] [rpm-software-management/rpm] Make API docs part of the reference manual (Issue #2216)

2022-10-04 Thread Panu Matilainen
This looks like one for @ffesti -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2216#issuecomment-1266463704 You are receiving this because you are subscribed to this thread. Message ID: ___

[Rpm-maint] [rpm-software-management/rpm] Make API docs part of the reference manual (Issue #2216)

2022-10-04 Thread Panu Matilainen
The API docs should be made part of the reference manual, appendix or something. The need for this is made rather painfully obvious by #2215. This may be more of a website thing than rpm codebase, but filing here as the docs layout does reflect the reference manual too and I've blissfully

Re: [Rpm-maint] [rpm-software-management/rpm] Add manual page for File Mode (PR #2215)

2022-10-04 Thread Panu Matilainen
@pmatilai commented on this pull request. > +### Example Modes + +These are some example mode strings suitable for the payload: + +| Mode | Description | +|---|---| +|`w9.gzdio`| gzip level 9, RPM

Re: [Rpm-maint] [rpm-software-management/rpm] Add manual page for File Mode (PR #2215)

2022-10-04 Thread Panu Matilainen
@pmatilai commented on this pull request. > + +``` +[flags]. +``` + +The `mode` parameter is mandatory and contains a sequence of letters as +described in `fopen(3)`. For payload configuration, only `w` is allowed. + +The `type` parameter is also mandatory and specifies the compression type

Re: [Rpm-maint] [rpm-software-management/rpm] Add manual page for File Mode (PR #2215)

2022-10-04 Thread Panu Matilainen
@pmatilai commented on this pull request. > + +These can include a compression level (from 0 to 9) and `T` followed by the +number of threads to be used during compression, where `T0` (or just `T`) means +that the optimal number of threads should automatically be chosen based on the

Re: [Rpm-maint] [rpm-software-management/rpm] Add manual page for File Mode (PR #2215)

2022-10-04 Thread Panu Matilainen
@pmatilai commented on this pull request. > + +These can include a compression level (from 0 to 9) and a strategy (e.g. `h` +for Huffman-only compression). See the description of `gzopen()` in +`/usr/include/zlib.h` for more details. + + BZIP2 Flags + +These can include a compression level

Re: [Rpm-maint] [rpm-software-management/rpm] Add manual page for File Mode (PR #2215)

2022-10-04 Thread Panu Matilainen
@pmatilai commented on this pull request. > @@ -0,0 +1,95 @@ +--- +layout: default +title: rpm.org - File Mode +--- +# File Mode + +RPM supports a variety of compression methods through external libraries for +its internal I/O operations. For ease of use, the [RPMIO

Re: [Rpm-maint] [rpm-software-management/rpm] Add manual page for File Mode (PR #2215)

2022-10-04 Thread Panu Matilainen
@pmatilai commented on this pull request. > + +``` +[flags]. +``` + +The `mode` parameter is mandatory and contains a sequence of letters as +described in `fopen(3)`. For payload configuration, only `w` is allowed. + +The `type` parameter is also mandatory and specifies the compression type