> But it is weird and makes it easy to unnecessarily draw attention to some
> language quirk while we can also just use totally fine C code.
Makes sense. (I think you meant #2436.) I attempted this more trivial solution
because I don't know well enough about the code. But I'm happy with
See #2434
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2434#issuecomment-1472593844
You are receiving this because you are subscribed to this thread.
Message ID: ___
Rpm-maint mailing list
Well, I had considered both of these options and decided against both of them.
Yes, adding an empty statement solves this. But it is weird and makes it easy
to unnecessarily draw attention to some language quirk while we can also just
use totally fine C code.
--
Reply to this email directly
@ZhongRuoyu pushed 1 commit.
132050c2ce68273cedd1f246a44720601a4bcdc0 Remove comment for empty statement
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2434/files/5375b90150b5468ea9985b81f10dc8fae20d9db4..132050c2ce68273cedd1f246a44720601a4bcdc0
You are receiving
@DemiMarie commented on this pull request.
> setmeta:
+ ; /* Empty statement for label */
/* Special files require path-based ops */
```suggestion
setmeta:;
/* Special files require path-based ops */
```
--
Reply to this email directly or view
Turns out declarations cannot be labeled according to the C standard. And while
some compilers dont seem to care others do.
Moving the declaration of mayopen to the start of the function to avoid this
problem.
Resolves: #2435
You can view, comment on, or merge this pull request online at:
Hi, i'm compiling rpm-4.18.1 with LLVM/clang-15.x and i get the following error:
```
/bin/sh ../libtool --tag=CC --mode=compile /usr/bin/clang -DHAVE_CONFIG_H
-I.. -I.. -I../include -I../misc -DLOCALEDIR="\"/usr/share/locale\""
-DSYSCONFDIR="\"/etc\"" -DLOCALSTATEDIR="\"/var\""
In C, a label should be followed by a statement, not a declaration. The
`setmeta` label in `lib/fsm.c` violated this, and led to a build error with an
error message like the one below:
```
fsm.c:1019:6: error: expected expression
int mayopen = S_ISREG(fp-sb.st_mode) ||
@ffesti pushed 1 commit.
92cdf843d49c428ca01049f374b2d26d490ed2a4 Describe the stripped down payload
format
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2433/files/e0153b162d6e73edc7437218ddb53deed8e3fe29..92cdf843d49c428ca01049f374b2d26d490ed2a4
You are receiving
in the reference manual
Resolves: #2413
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2433
-- Commit Summary --
* Describe the stripped down payload format
-- File Changes --
M docs/manual/format.md (8)
-- Patch
@pmatilai pushed 1 commit.
6bf0c212d04154bd5a5f2cfb763f5725a25e2af4 fixup! Automatically create sysuser
users and groups on install
--
View it on GitHub:
See #2432
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/discussions/2277#discussioncomment-562
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint
Thanks for the patch!
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2429#issuecomment-1471852235
You are receiving this because you are subscribed to this thread.
Message ID: ___
Rpm-maint
Merged #2429 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2429#event-8766612900
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint
@marxin pushed 1 commit.
b1085655b44723c92893efa8cb06399f83ab26af add more libmagic exceptions for
HTML, SVG and PNG
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2429/files/172c00172f8d84836cd57d07d46db2cd4dbf8c2d..b1085655b44723c92893efa8cb06399f83ab26af
You are
First, RPM does dependency checks for every type of operation. While the cli
only offers certain operations updaters and other API users can do more complex
operations. So matching the errors to the operation is not going to happen.
This is a generic error than can be caused by any type of
Closed #2428 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2428#event-8766560643
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint
Apart from that unicode thing, ack, I guess.
But needing to do more and more of such overrides, it questions the involvement
of libmagic in the first place...
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2429#issuecomment-1471831448
@pmatilai commented on this pull request.
> @@ -1181,6 +1181,9 @@ static const struct skipped_extension_s
> skipped_extensions[] = {
{ ".h", "C Header", "text/x-c" },
{ ".la", "libtool library file", "text/plain" },
{ ".pc", "pkgconfig file",
Sorry, my vim does that automatically. Will do the white space fixes in a
different commit
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2431#issuecomment-1471774196
You are receiving this because you are subscribed to this thread.
I see maybe one actual typo fix and a whole lot of trailing whitespace removed.
Rule #1 of commits: never ever mix mere whitespace changes with other stuff.
Even for documentation.
--
Reply to this email directly or view it on GitHub:
@pmatilai pushed 2 commits.
4957da799d1b7d8f93d131acad2c119dbb89e063 Automatically create sysuser users
and groups on install
896a9a9c70649f63ccb2f4eb4f6d0a4f5e480eaf Autogenerate requires for users and
groups in packages from file data
--
View it on GitHub:
@pmatilai pushed 2 commits.
427a49a9234a1115401f08a2877b010cc0d3ac02 Automatically create sysuser users
and groups on install
403c34a5fbe1ef90f92f92a87a1f89f9efba1c2f Autogenerate requires for users and
groups in packages from file data
--
View it on GitHub:
This is a work-in-progress PR for declarative user and group handling, ie #1032
and https://github.com/rpm-software-management/rpm/discussions/2277
The executive summary is: if you ship sysusers.d(5) files in your packages, you
never need to muck with user or group creation in specs again.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2431
-- Commit Summary --
* triggers.md: fix a typo
-- File Changes --
M docs/manual/triggers.md (14)
-- Patch Links --
That's pretty funny :smile: I never so much as noticed there was a buildtime
being included... and this is probably why the earlier test uses a custom
queryformat instead of 'rpm -qpl'. Probably goes back to times before we had
these source_date_epoch thingies...
--
Reply to this email
@pmatilai pushed 1 commit.
f8bd1602bbd37591cd1333e2559e3110d22f7902 Populate user and group data in cpio
payload again
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2430/files/2268bceb260f9c5118dfba8d854354a9e1020b1d..f8bd1602bbd37591cd1333e2559e3110d22f7902
You
Looks like the CI agrees with me...
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2430#issuecomment-1471643133
You are receiving this because you are subscribed to this thread.
Message ID:
I doubt that checking for the build time will work for long. You either need to
check in the package, set the file dates manually or filter out the dates in
the output.
--
Reply to this email directly or view it on GitHub:
In general, rpm populates the cpio header with the same info as the file lists
in the header, although it only uses the latter. This is even documented in LSB
(up to and including version 5). At some point, the user and group information
has gotten dropped though, all files end up owned by
30 matches
Mail list logo
