Re: [Rpm-maint] [rpm-software-management/rpm] Replace fakechroot with proper container technology (PR #2559)

2023-07-12 Thread Demi Marie Obenour
@dmnks There is a FUSE implementation of OverlayFS that also supports the BSDs. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2559#issuecomment-165921 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Replace fakechroot with proper container technology (PR #2559)

2023-07-12 Thread Michal Domonkos
> At that point, adding a legacy backend using fakechroot (or just chroot > perhaps) would be a possibility and while I won't make any promises, I > _might_ look at that later. Hmm, I totally forgot that `chroot` alone wouldn't suffice, the system would also need to have something like

[Rpm-maint] [rpm-software-management/rpm] RPM DB query creates DB directory and files (Issue #2572)

2023-07-12 Thread Shreenidhi Shedi
If a query is run specifying a non existent dbpath, rpm implictly creates a db directory and db files at the specified location. For example: ``` mkdir t cd t rpm -q rpm --dbpath $PWD/t ``` The above commands result in: ``` root@ph5dev:~ # mkdir t mkdir: created directory 't' root@ph5dev:~ # cd

Re: [Rpm-maint] [rpm-software-management/rpm] Fix missing includes on macOS (PR #2571)

2023-07-12 Thread Neal Gompa
@Conan-Kudo approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2571#pullrequestreview-1526434141 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Fix missing includes on macOS (PR #2571)

2023-07-12 Thread Calvin Buckley
@NattyNarwhal pushed 1 commit. cd8878d51fc1d8dc177bed2a4e622eb07570a91c Cast to fix constiness checks -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2571/files/56831f16ff2588bc61c9a252fb3157f5246c47f7..cd8878d51fc1d8dc177bed2a4e622eb07570a91c You are receiving this

Re: [Rpm-maint] [rpm-software-management/rpm] Fix missing includes on macOS (PR #2571)

2023-07-12 Thread Calvin Buckley
That's weird, `basename(3)` should take a `char*`, not `const char*`, per the glibc and macOS man page. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2571#issuecomment-163278 You are receiving this because you are subscribed to

Re: [Rpm-maint] [rpm-software-management/rpm] Replace fakechroot with proper container technology (PR #2559)

2023-07-12 Thread Michal Domonkos
Anyway, the timing of your question was just right as I had been contemplating just about the same thing, i.e. whether to decouple the test suite *completely* from the sandboxing method used or make bwrap hardwired. (It's also one of the reasons this PR is *still* not merged, sigh.) This is a

Re: [Rpm-maint] [rpm-software-management/rpm] Replace fakechroot with proper container technology (PR #2559)

2023-07-12 Thread Michal Domonkos
> Oh, so you do have a fakechroot build (in that VM) that works fine with the > test suite, correct? Nah, disregard that, you just confirmed that in your reply: > but [fakeroot](https://salsa.debian.org/clint/fakeroot) is supposed to work > on macOS and is [available via >

Re: [Rpm-maint] [rpm-software-management/rpm] Replace fakechroot with proper container technology (PR #2559)

2023-07-12 Thread Michal Domonkos
Oh, so you do have a fakechroot build (in that VM) that works fine with the test suite, correct? I mean, it's not a huge program with a lot of dependencies anyway (and `chroot()`, which AFAIK is used underneath, is a POSIX function, as you said), so it's probably easier to port than a full

Re: [Rpm-maint] [rpm-software-management/rpm] Replace fakechroot with proper container technology (PR #2559)

2023-07-12 Thread Neal Gompa
I have a virtual machine with macOS that I do destructive things in. Occasionally that includes running the test suite, but even just making a build environment for RPM in macOS manually (and avoiding homebrew) is pretty messy, so I do all that work in a dedicated virtual machine. -- Reply to

Re: [Rpm-maint] [rpm-software-management/rpm] Replace fakechroot with proper container technology (PR #2559)

2023-07-12 Thread Michal Domonkos
> Darwin has `chroot()` like all POSIX systems. I'm not sure if `fakechroot` > works on Darwin, but [`fakeroot`](https://salsa.debian.org/clint/fakeroot) is > supposed to work on macOS and is [available via > homebrew](https://formulae.brew.sh/formula/fakeroot). > > Darwin also has the sandbox

Re: [Rpm-maint] [rpm-software-management/rpm] Replace fakechroot with proper container technology (PR #2559)

2023-07-12 Thread Michal Domonkos
Since I already started describing the new architecture, here's a perhaps simpler outline of how it works now (`mktree` is wired into the `make`): 1) `mktree build` * builds a base OS tree * builds RPM natively and make installs it into the base OS tree 2) `mktree check` * runs `rpmtests`

Re: [Rpm-maint] [rpm-software-management/rpm] Replace fakechroot with proper container technology (PR #2559)

2023-07-12 Thread Neal Gompa
Darwin has `chroot()` like all POSIX systems. I'm not sure if `fakechroot` works on Darwin, but [`fakeroot`](https://salsa.debian.org/clint/fakeroot) is supposed to work on macOS and is [available via homebrew](https://formulae.brew.sh/formula/fakeroot). Darwin also has the sandbox API (which

Re: [Rpm-maint] [rpm-software-management/rpm] Replace fakechroot with proper container technology (PR #2559)

2023-07-12 Thread Michal Domonkos
Bubblewrap (bwrap) is used here to create fast, ephemeral per-test containers (*snapshots*) of the root filesystem. This replaces the former use of fakechroot. The whole test suite (the `rpmtests` script) assumes that the RPM build to be tested is installed into the root filesystem. That

Re: [Rpm-maint] [rpm-software-management/rpm] fix "no compatible architectures" in riscv32 (PR #2540)

2023-07-12 Thread Neal Gompa
Yocto will probably wind up using this too, since they support the RPM stack with architectures like this. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2540#issuecomment-1632250845 You are receiving this because you are subscribed to

Re: [Rpm-maint] [rpm-software-management/rpm] Replace fakechroot with proper container technology (PR #2559)

2023-07-12 Thread Neal Gompa
What do we do if we want to run the test suite on non-Linux? Like macOS? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2559#issuecomment-1632247013 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Fix missing includes on macOS (PR #2571)

2023-07-12 Thread Neal Gompa
@Conan-Kudo requested changes on this pull request. Looks like this isn't working exactly: >From CI: ``` [ 73%] Building C object CMakeFiles/rpmuncompress.dir/tools/rpmuncompress.c.o /srv/rpm/tools/rpmuncompress.c: In function 'doUntar': /srv/rpm/tools/rpmuncompress.c:101:39: error: passing

Re: [Rpm-maint] [rpm-software-management/rpm] Fix missing includes on macOS (PR #2571)

2023-07-12 Thread Neal Gompa
@Conan-Kudo approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2571#pullrequestreview-1526020644 You are receiving this because you are subscribed to this thread. Message ID: