Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Standardize on OCI images for test-suite, even locally (Issue #2643)

2023-09-26 Thread ニール・ゴンパ
Well, apparently this is now a thing: https://macoscontainers.org/ -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2643#issuecomment-1736575490 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Add a new perl.prov script to generate normalized module versions (PR #2586)

2023-09-26 Thread tinita
I created https://github.com/perlpunk/rpm-perl For now it just contains copies of the original perl files. Which license should I use? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2586#issuecomment-1736244646 You are receiving this

Re: [Rpm-maint] [rpm-software-management/rpm] Move checks and package initialization after build (PR #2646)

2023-09-26 Thread Panu Matilainen
What exactly is this supposed to mean in the context of the "move checks and package init after build" commit? > NAME, VERSION, RELEASE, (EPOCH) is needed for all sub packages and the source > rpm for the build. The srpm also needs ARCH, OS and the BuildRequires. Just tested, and rpmbuild will

Re: [Rpm-maint] [rpm-software-management/rpm] Move checks and package initialization after build (PR #2646)

2023-09-26 Thread Panu Matilainen
@pmatilai commented on this pull request. > @@ -37,6 +37,7 @@ enum rpmSpecFlags_e { RPMSPEC_FORCE = (1 << 1), RPMSPEC_NOLANG = (1 << 2), RPMSPEC_NOUTF8 = (1 << 3), +RPMSPEC_DONTFINALIZE = (1 << 4), Use "NO" instead of "DONT" for consistency with the rest of rpm.

Re: [Rpm-maint] [rpm-software-management/rpm] Move checks and package initialization after build (PR #2646)

2023-09-26 Thread Panu Matilainen
I'm getting a bunch of warnings about free() of uninitialized value in finalizeSpec() and the warnings are valid, as the first goto can jump over the declaration entirely. But, that should be tripping up the CI compile stage already. Have we lost ENABLE_WERROR=ON there? -- Reply to this

Re: [Rpm-maint] [rpm-software-management/rpm] Move checks and package initialization after build (PR #2646)

2023-09-26 Thread Panu Matilainen
In the meanwhile, spotted at least one problem: dropping the NVR argument from checkForRequired() breaks in the case of Name tag missing from the main package. As that can only happen with the main package, should be easy enough to work around though. -- Reply to this email directly or view

Re: [Rpm-maint] [rpm-software-management/rpm] Move checks and package initialization after build (PR #2646)

2023-09-26 Thread Panu Matilainen
Actually, please drop the move commit out of this set. That's what makes so unrevieable on GH, and that's not even an interesting commit in itself :sweat_smile: -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Move checks and package initialization after build (PR #2646)

2023-09-26 Thread Panu Matilainen
The actual commits look a whole lot more approachable now, only the GH interface is totally inadequate for this kind of job... but lets try. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2646#issuecomment-1735245703 You are receiving