[Rpm-maint] [rpm-software-management/rpm] [Question] How to understand the immutable header regions introduced from RPM 4.0 (Issue #2718)

2023-10-12 Thread Hu Sheng
There is a document introducing the immutable header regions [here](https://rpm-software-management.github.io/rpm/manual/hregions.html), But it's hard for someone who is unfamiliar with the history to understand, my question how to understand the immutable header regions? How to make it

Re: [Rpm-maint] [rpm-software-management/rpm] Remove the internal OpenPGP parser (Issue #2414)

2023-10-12 Thread Panu Matilainen
The really annoying part about this is that if it wasn't for the stupid pgpIdentItem() function in librpmio, we could just hide a these two val->string conversions into a private helpers someplace in librpm. Back when it was added, pgpIdentItem() was a shortcut to avoid exposing a struct or a

Re: [Rpm-maint] [rpm-software-management/rpm] Remove the internal OpenPGP parser (Issue #2414)

2023-10-12 Thread Panu Matilainen
I did some cleanup surrounding this today, managed to remove quite a bit of related unused cruft that has been just sitting there for twenty years. We're now annoyingly close to be able to bury the rpmpgpval.h table stuff into the internal parser too. The only things needing that data now in

Re: [Rpm-maint] [rpm-software-management/rpm] Please remove the "absolute symlink" warnings (Issue #2419)

2023-10-12 Thread Panu Matilainen
Yes, like I said, the warning is a piece of education from the upstream. I see no reason why distros should make a special statement about this whatsoever. If *you* feel so, then *you* go file a request about it. By all means. -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Please remove the "absolute symlink" warnings (Issue #2419)

2023-10-12 Thread Vít Ondruch
The guideline is in Fedora at least as long as the Git history goes, which is 5 years. The warning landed in RPM ~3.5 years ago. So if the RPM was pushed into Fedora by the RPM team, it would be just fair to make sure that the guidelines are aligned with what RPM does. In this case, RPM is

Re: [Rpm-maint] [rpm-software-management/rpm] Public rpmpgp.h header mass cleanup (PR #2717)

2023-10-12 Thread Panu Matilainen
Yes - there's nothing in our API that exposes data through those structs. If somebody has been basing their own parser by including that header then .. they're just going to have to invent their own structs now... -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Public rpmpgp.h header mass cleanup (PR #2717)

2023-10-12 Thread Neal H. Walfield
You've removed types from the public API. Are you sure that is okay? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2717#issuecomment-1759452972 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Public rpmpgp.h header mass cleanup (PR #2717)

2023-10-12 Thread Panu Matilainen
Merged #2717 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2717#event-10630492042 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Please remove the "absolute symlink" warnings (Issue #2419)

2023-10-12 Thread Panu Matilainen
Sorry but I don't go around lecturing distros what they should or shouldn't do. That's what the warning is for. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2419#issuecomment-1759440435 You are receiving this because you are

Re: [Rpm-maint] [rpm-software-management/rpm] Public rpmpgp.h header mass cleanup (PR #2717)

2023-10-12 Thread Panu Matilainen
@nwalfield, just FYI -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2717#issuecomment-1759419029 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

[Rpm-maint] [rpm-software-management/rpm] Public rpmpgp.h header mass cleanup (PR #2717)

2023-10-12 Thread Panu Matilainen
The RFCs are online accessible to everybody, no reason to carry all a copy of an outdated draft in rpm. Remove unused structs, and move used ones into the internal parser. Nothing else needs this stuff, never has. No functional changes. You can view, comment on, or merge this pull request

Re: [Rpm-maint] [rpm-software-management/rpm] Non-adequate 'curl' command defined in the rpm configuration (Issue #2384)

2023-10-12 Thread Panu Matilainen
Closed #2384 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2384#event-10629897956 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Non-adequate 'curl' command defined in the rpm configuration (Issue #2384)

2023-10-12 Thread Panu Matilainen
This has nothing to do with curl or rpm, and everything to do with a filename that doesn't exist: ``` libvirt-client-0:8.6.0-3.fc37.x86_64.rpm ^^ ``` Rpm filenames don't carry epoch numbers, by old tradition. -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Please remove the "absolute symlink" warnings (Issue #2419)

2023-10-12 Thread Vít Ondruch
Or this should be configurable and Fedora should be able to choose to configure RPM in a way that it is consistent with their guidelines. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2419#issuecomment-1759344842 You are receiving

Re: [Rpm-maint] [rpm-software-management/rpm] Please remove the "absolute symlink" warnings (Issue #2419)

2023-10-12 Thread Vít Ondruch
Then could you please do me a favor and propose update to Fedora packaging guidelines? I won't do it myself, because I disagree with this and consider the current guidelines to be correct. But they should be in line with what RPM thinks if RPM changes its mind. -- Reply to this email directly

Re: [Rpm-maint] [rpm-software-management/rpm] Please remove the "absolute symlink" warnings (Issue #2419)

2023-10-12 Thread Panu Matilainen
Closed #2419 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2419#event-10629723475 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Please remove the "absolute symlink" warnings (Issue #2419)

2023-10-12 Thread Panu Matilainen
Rpm chroot installations and the associated problems (yes, content pointing to system locations with a non-trivial risk of breaking things badly) with absolute links are not specific to Fedora in any way. The warning is there for a reason and the way to avoid it is to convert to relative links,

Re: [Rpm-maint] [rpm-software-management/rpm] Minor cleanups towards detaching rpmpgp_legacy from rpm internals (PR #2716)

2023-10-12 Thread Neal H. Walfield
No worries. I figured that after I looked at it, but then I had already looked at it :D -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2716#issuecomment-1759253541 You are receiving this because you are subscribed to this thread.

Re: [Rpm-maint] [rpm-software-management/rpm] Minor cleanups towards detaching rpmpgp_legacy from rpm internals (PR #2716)

2023-10-12 Thread Panu Matilainen
Oh, I didn't tag you in because I figured this is just uninteresting paper-shuffling type cleanup :sweat_smile: -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2716#issuecomment-1759229407 You are receiving this because you are

Re: [Rpm-maint] [rpm-software-management/rpm] Minor cleanups towards detaching rpmpgp_legacy from rpm internals (PR #2716)

2023-10-12 Thread Neal H. Walfield
I reviewed the change and it looks reasonable to me. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2716#issuecomment-1759201594 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Minor cleanups towards detaching rpmpgp_legacy from rpm internals (PR #2716)

2023-10-12 Thread Panu Matilainen
Merged #2716 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2716#event-1062878 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Minor cleanups towards detaching rpmpgp_legacy from rpm internals (PR #2716)

2023-10-12 Thread Panu Matilainen
This is nowhere near sufficient to make rpmpgp_legacy buildable outside rpm but this much is easy so why not. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2716#issuecomment-1759187015 You are receiving this because you are subscribed

[Rpm-maint] [rpm-software-management/rpm] Minor cleanups towards detaching rpmpgp_legacy from rpm internals (PR #2716)

2023-10-12 Thread Panu Matilainen
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/2716 -- Commit Summary -- * Refactor internal PGP parser pgpValStr() uses to use the public API * Bury pgpValStr() inside rpmpgp.c now that we can * Drop unneeded

Re: [Rpm-maint] [rpm-software-management/rpm] Move internal OpenPGP parser into a subdirectory (PR #2704)

2023-10-12 Thread Panu Matilainen
Merged #2704 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2704#event-10628393339 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Move internal OpenPGP parser into a subdirectory (PR #2704)

2023-10-12 Thread Panu Matilainen
Tweaked a little bit to make the legacy status more prominent in the naming. Just another small step towards sawing this unwanted limb off :smile: -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2704#issuecomment-1759145173 You are

Re: [Rpm-maint] [rpm-software-management/rpm] Move internal OpenPGP parser into a subdirectory (PR #2704)

2023-10-12 Thread Panu Matilainen
@pmatilai pushed 0 commits. -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2704/files/77c71398d93ede2bb636aca9f9038f78a52a54b7..c289eba9defacf550768c3cc5e64f17d72c7e6bc You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Move internal OpenPGP parser into a subdirectory (PR #2704)

2023-10-12 Thread Panu Matilainen
@pmatilai pushed 3 commits. c289eba9defacf550768c3cc5e64f17d72c7e6bc Move internal OpenPGP parser into a subdirectory 9b24d952dda0d8a42a7b325937a94d4d92b56dec Refactor internal PGP parser pgpValStr() uses to use the public API 77c71398d93ede2bb636aca9f9038f78a52a54b7 Bury pgpValStr() inside

Re: [Rpm-maint] [rpm-software-management/rpm] Move internal OpenPGP parser into a subdirectory (PR #2704)

2023-10-12 Thread Panu Matilainen
@pmatilai pushed 1 commit. 9aa8abb10ab12ccb9cf93327533a9f1cf00e97b2 Move internal OpenPGP parser into a subdirectory -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2704/files/43d8557c30c1cc5d4618128bee5c0079205ced31..9aa8abb10ab12ccb9cf93327533a9f1cf00e97b2 You are

Re: [Rpm-maint] [rpm-software-management/rpm] Host specific %_install_langs affects --root installation (Issue #2623)

2023-10-12 Thread Pavel Raiskup
Yes, correct. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2623#issuecomment-1758963263 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing