Re: [Rpm-maint] [rpm-software-management/rpm] if-else rich dependency always installs the if leg (Issue #3082)

2024-05-07 Thread Zbigniew Jędrzejewski-Szmek
Thanks. You are completely right, I misunderstood what is part of the stack is doing what. I added the Suggests as suggested, and it works. Thanks again. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3082#issuecomment-2098790412 You

Re: [Rpm-maint] [rpm-software-management/rpm] if-else rich dependency always installs the if leg (Issue #3082)

2024-05-07 Thread Zbigniew Jędrzejewski-Szmek
Closed #3082 as not planned. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3082#event-12731802803 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [Rpm-maint] [rpm-software-management/rpm] if-else rich dependency always installs the if leg (Issue #3082)

2024-05-07 Thread Michael Schroeder
This is not a rpm issue. rpm just checks if all dependencies are fulfilled, it does not choose packages. So you would need to take this to the dnf people who will tell you to ask the libsolv folks. Anyway, what happens is that your dependency is basically telling the solver "either install

Re: [Rpm-maint] [rpm-software-management/rpm] Convert packageHash to STL unordered_map (PR #3077)

2024-05-07 Thread Panu Matilainen
...plus a bunch of other hashes... -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3077#issuecomment-2098143569 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [Rpm-maint] [rpm-software-management/rpm] Convert packageHash to STL unordered_map (PR #3077)

2024-05-07 Thread Panu Matilainen
@pmatilai pushed 1 commit. 24b61052131553275d5818e1a47bce6a3c80f7ba Replace dependency lookup cache with an STL unordered map -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/3077/files/cce0bdbc8c1e48cb03bb2905d4c7cbd3340a..24b61052131553275d5818e1a47bce6a3c80f7ba

Re: [Rpm-maint] [rpm-software-management/rpm] if-else rich dependency always installs the if leg (Issue #3082)

2024-05-07 Thread Zbigniew Jędrzejewski-Szmek
https://src.fedoraproject.org/fork/zbyszek/rpms/redhat-rpm-config/commits/post-build-reproducibility-debug is the branch. The middle commit shows the unexpected behaviour and the third one is for debugging. -- Reply to this email directly or view it on GitHub:

[Rpm-maint] [rpm-software-management/rpm] if-else rich dependency always installs the if leg (Issue #3082)

2024-05-07 Thread Zbigniew Jędrzejewski-Szmek
**Describe the bug** The docs say: > `if` - requires the first operand to be fulfilled if the second is (reverse > implication) > `if else` - same as above but requires the third operand to be fulfilled if > the second is not I added the following to `redhat-rpm-macros`: > `Requires:

[Rpm-maint] [rpm-software-management/rpm] Use an STL vector for the transaction main rpmte pointer storage (PR #3081)

2024-05-07 Thread Panu Matilainen
...and orderInfo array too You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/3081 -- Commit Summary -- * Replace the annoying keyid stash with an STL set * Use an STL vector for the transaction main rpmte pointer storage

[Rpm-maint] [rpm-software-management/rpm] Replace the annoying keyid stash with an STL set (PR #3080)

2024-05-07 Thread Panu Matilainen
It still needs to die, but theres less code that needs dying... You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/3080 -- Commit Summary -- * Replace the annoying keyid stash with an STL set -- File Changes -- M

[Rpm-maint] [rpm-software-management/rpm] Simplify rpmfi replaced sized management (PR #3079)

2024-05-07 Thread Panu Matilainen
rpmfi always internally stores 64bit sizes since 4.6.0, theres no reason to do anything else with replaced sizes either. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/3079 -- Commit Summary -- * Simplify rpmfi replaced

[Rpm-maint] [rpm-software-management/rpm] Replace rpmhash with STL unordered_map in headerformat cache (PR #3078)

2024-05-07 Thread Panu Matilainen
A notable difference is that were now storing the rpmtd structs themselves in the hash, rather than pointers to them. A minor side-cleanup is that headerGet() does not return data on failure so theres no need to free anything in that case. You can view, comment on, or merge this pull request

Re: [Rpm-maint] [rpm-software-management/rpm] Convert packageHash to STL unordered_map (PR #3077)

2024-05-07 Thread Panu Matilainen
@pmatilai pushed 2 commits. 85b181479291fa0f1a5a7f202fc1849c998b3faf Natively allocate the main file trigger structs cbbfe1ee74859818cf45c4a7b2812541216ef51f Convert packageHash to STL unordered_map -- View it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Implement proper user/group lookup caching with STL maps (PR #3076)

2024-05-07 Thread Panu Matilainen
Merged #3076 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3076#event-12724208939 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

[Rpm-maint] [rpm-software-management/rpm] Convert packageHash to STL unordered_map (PR #3077)

2024-05-07 Thread Panu Matilainen
This was a particularly ugly case as it was defined in multiple places. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/3077 -- Commit Summary -- * Convert packageHash to STL unordered_map -- File Changes -- M

Re: [Rpm-maint] [rpm-software-management/rpm] Convert rpmal to use STL containers (PR #3075)

2024-05-07 Thread Panu Matilainen
Merged #3075 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3075#event-12723879896 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint