Re: [Rpm-maint] [Suse patch] Checking for identical packages on install/upgrade

2007-06-08 Thread Michael Schroeder
On Fri, Jun 08, 2007 at 07:44:21AM +0300, Panu Matilainen wrote: > Hmm, right. Care to whip up an updated patch that does what you described? The patch is in my other mail about psm.c. > And adding an error message wouldn't hurt either :) Well, that's deep in psm.c. What happens is that stage P

Re: [Rpm-maint] [Suse patch] Checking for identical packages on install/upgrade

2007-06-07 Thread Panu Matilainen
On Tue, 5 Jun 2007, Michael Schroeder wrote: On Mon, Jun 04, 2007 at 11:00:16AM +0300, Panu Matilainen wrote: Please do. I'm not claiming you're not right, seeing the problem would help *me* understand it properly :) Say you have Jeff's rpmHeadersIdentical() in depend.cs. If you have two pack

Re: [Rpm-maint] [Suse patch] Checking for identical packages on install/upgrade

2007-06-05 Thread Michael Schroeder
On Mon, Jun 04, 2007 at 11:00:16AM +0300, Panu Matilainen wrote: > Please do. I'm not claiming you're not right, seeing the problem would > help *me* understand it properly :) Say you have Jeff's rpmHeadersIdentical() in depend.cs. If you have two packages with same NEVR but different PKGIDs, the

Re: [Rpm-maint] [Suse patch] Checking for identical packages on install/upgrade

2007-06-04 Thread Panu Matilainen
On Fri, 1 Jun 2007, Michael Schroeder wrote: On Fri, Jun 01, 2007 at 01:08:28PM +0300, Panu Matilainen wrote: Um, sorry but I'm not following... where does freshen come to play in the bug https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=104066 mentioned in the patch? Freshen won't even tou

Re: [Rpm-maint] [Suse patch] Checking for identical packages on install/upgrade

2007-06-01 Thread Michael Schroeder
On Fri, Jun 01, 2007 at 01:08:28PM +0300, Panu Matilainen wrote: > Um, sorry but I'm not following... where does freshen come to play in the > bug https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=104066 mentioned > in the patch? Freshen won't even touch the other package there because the >

Re: [Rpm-maint] [Suse patch] Checking for identical packages on install/upgrade

2007-06-01 Thread Panu Matilainen
On Tue, 29 May 2007, Michael Schroeder wrote: On Tue, May 29, 2007 at 10:29:45AM +0300, Panu Matilainen wrote: What JBJ does here is checks HDRID for identifying identical packages if present, version comparison if not. But I don't think it's actually identicality of headers (or not) we're real

Re: [Rpm-maint] [Suse patch] Checking for identical packages on install/upgrade

2007-05-29 Thread Michael Schroeder
On Tue, May 29, 2007 at 10:29:45AM +0300, Panu Matilainen wrote: > What JBJ does here is checks HDRID for identifying identical packages if > present, version comparison if not. But I don't think it's actually > identicality of headers (or not) we're really interested in here but > upgradability

Re: [Rpm-maint] [Suse patch] Checking for identical packages on install/upgrade

2007-05-29 Thread Paul Nasrat
On Tue, 2007-05-29 at 10:29 +0300, Panu Matilainen wrote: > For full background see > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=104066. And yes I do > think it's a bug that we should fix. > > I'd rather just use rpmdsCompare() for the check rather than add yet > another codepath for

[Rpm-maint] [Suse patch] Checking for identical packages on install/upgrade

2007-05-29 Thread Panu Matilainen
For full background see https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=104066. And yes I do think it's a bug that we should fix. What JBJ does here is checks HDRID for identifying identical packages if present, version comparison if not. But I don't think it's actually identicality of