Re: [Rpm-maint] [rpm-software-management/rpm] %mkbuilddir breaks the %generate_buildrequires implementation in mock (Issue #3121)

2024-05-23 Thread Panu Matilainen
Closed #3121 as completed via #3122. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3121#event-12906903696 You are receiving this because you are subscribed to this thread. Message ID: ___

Re: [Rpm-maint] [rpm-software-management/rpm] %mkbuilddir breaks the %generate_buildrequires implementation in mock (Issue #3121)

2024-05-23 Thread Panu Matilainen
The biggest issue here was really that there were no tests on --noprep whatsoever, so when I wasn't even aware of the feature... luckily this was easy enough to sort out. *knocks wood* -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] %mkbuilddir breaks the %generate_buildrequires implementation in mock (Issue #3121)

2024-05-23 Thread Panu Matilainen
I'm not sure there's much to do about that now, the ship sailed a long ago. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3121#issuecomment-2126653511 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] %mkbuilddir breaks the %generate_buildrequires implementation in mock (Issue #3121)

2024-05-23 Thread Miro Hrončok
>From @pmatilai at #3121: > I can see why mock would use such a thing, but I'm not really comfortable > with that (or the option itself) because it seems that mock is now driving > the build and not rpmbuild. And this means any changes to rpmbuild are even > more difficult than they are

Re: [Rpm-maint] [rpm-software-management/rpm] %mkbuilddir breaks the %generate_buildrequires implementation in mock (Issue #3121)

2024-05-23 Thread Michal Domonkos
Seconded, these were almost unusually detailed and actionable, thanks guys! -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3121#issuecomment-2126536301 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] %mkbuilddir breaks the %generate_buildrequires implementation in mock (Issue #3121)

2024-05-23 Thread Panu Matilainen
Thanks BTW @hroncok and @praiskup for the detailed reports! -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3121#issuecomment-2126518649 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] %mkbuilddir breaks the %generate_buildrequires implementation in mock (Issue #3121)

2024-05-22 Thread Panu Matilainen
As I said in #3120, my first reaction was: we have --noprep? :flushed: Git reveals the following: ``` commit 4f69f8b482e1bd61d5a7e1c8214e2ebc6cb66c5d Author: David Greaves Date: Tue May 26 12:31:51 2015 +0200 rpmbuild: Add "--noprep" to not execute %prep stage ``` So, no wonder I didn't

Re: [Rpm-maint] [rpm-software-management/rpm] %mkbuilddir breaks the %generate_buildrequires implementation in mock (Issue #3121)

2024-05-22 Thread Pavel Raiskup
Hehe, this is a complete coincidence (no prior talk with Miro about this) - I just debugged two FTBFSs the Python team opened (weeks ago) against the packages I maintain. Kudos the Python team can explore these problems before they even land Rawhide! -- Reply to this email directly or view

Re: [Rpm-maint] [rpm-software-management/rpm] %mkbuilddir breaks the %generate_buildrequires implementation in mock (Issue #3121)

2024-05-22 Thread Michal Domonkos
Note that a dupe was filed just minutes before this one: #3120. Funny timing, isn't it? :smile: -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/3121#issuecomment-2124889120 You are receiving this because you are subscribed to this

[Rpm-maint] [rpm-software-management/rpm] %mkbuilddir breaks the %generate_buildrequires implementation in mock (Issue #3121)

2024-05-22 Thread Miro Hrončok
**Describe the bug** RPM 4.20 breaks all Fedora packages with %generate_buildrequires (when built in mock, koji, etc.). The error looks like this: ``` Executing(%generate_buildrequires): /bin/sh -e /var/tmp/rpm-tmp.nQJoQh + umask 022 + cd /builddir/build/BUILD/python-cffi-1.16.0-build + cd