@Conan-Kudo commented on this pull request.
> +# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY
> RIGHTS. IN
+# NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
+# DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
+# OTHERWISE,
@keszybz commented on this pull request.
> +# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY
> RIGHTS. IN
+# NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
+# DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
+# OTHERWISE,
@keszybz commented on this pull request.
> +
+printf 'Installed-Build-Depends:\n' >> "$BUILDINFO"
+rpm -qa --queryformat '%{epoch}:%{name}-%{version}-%{release}.%{arch}\n' \
+| LC_ALL=C sort -t: -k2 \
+| sed -e 's/^(none)://; /\.(none)$/d; s/^/ /' >> "$BUILDINFO"
+
+printf
@Conan-Kudo commented on this pull request.
> +# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY
> RIGHTS. IN
+# NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
+# DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
+# OTHERWISE,
@Conan-Kudo commented on this pull request.
> +
+printf '%s' "\
+Format: 1.0
+BuildArchitecture: ${RPM_BUILD_ARCH}
+Name: ${RPM_PACKAGE_NAME}
+Epoch: ${RPM_PACKAGE_EPOCH}
+Version: ${RPM_PACKAGE_VERSION}
+Release: ${RPM_PACKAGE_RELEASE}
+Architecture: ${RPM_ARCH}
+BuildOS: ${RPM_BUILD_OS}
@keszybz commented on this pull request.
> +# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF THIRD PARTY
> RIGHTS. IN
+# NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
+# DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
+# OTHERWISE,
@DemiMarie commented on this pull request.
> +# in this Software without prior written authorization of the copyright
> holder.
+#
+
+set -e -o pipefail
+
+getos() {
+# shellcheck disable=SC1091
+test -r /etc/os-release && . /etc/os-release
+if test -z "${ID}"; then
+
@Conan-Kudo commented on this pull request.
> +# in this Software without prior written authorization of the copyright
> holder.
+#
+
+set -e -o pipefail
+
+getos() {
+# shellcheck disable=SC1091
+test -r /etc/os-release && . /etc/os-release
+if test -z "${ID}"; then
+
@marmarek commented on this pull request.
> +# in this Software without prior written authorization of the copyright
> holder.
+#
+
+set -e -o pipefail
+
+getos() {
+# shellcheck disable=SC1091
+test -r /etc/os-release && . /etc/os-release
+if test -z "${ID}"; then
+
@Conan-Kudo commented on this pull request.
> +# in this Software without prior written authorization of the copyright
> holder.
+#
+
+set -e -o pipefail
+
+getos() {
+# shellcheck disable=SC1091
+test -r /etc/os-release && . /etc/os-release
+if test -z "${ID}"; then
+
Closed #1532.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1532#event-7866567762
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint mailing list
This doesn't seem to go anywhere. So I am closing this PR here. Feel free to
re-open or may be open a new one. The discussion is becoming a bit unwieldy.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1532#issuecomment-1323478239
You
Thank you all for your feedback, I'll prepare another iteration soon with all
the comments here.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@fepitre commented on this pull request.
> +
+printf 'Installed-Build-Depends:\n' >> "$BUILDINFO"
+rpm -qa --queryformat '%{epoch}:%{name}-%{version}-%{release}.%{arch}\n' \
+| LC_ALL=C sort -t: -k2 \
+| sed -e 's/^(none)://; /\.(none)$/d; s/^/ /' >> "$BUILDINFO"
+
+printf
@Conan-Kudo commented on this pull request.
> +
+mkdir -p "$BUILDINFO_DIR"
+
+cat > "$BUILDINFO" <> "$BUILDINFO"
I'm fine with another filename.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@Conan-Kudo commented on this pull request.
> +
+printf 'Installed-Build-Depends:\n' >> "$BUILDINFO"
+rpm -qa --queryformat '%{epoch}:%{name}-%{version}-%{release}.%{arch}\n' \
+| LC_ALL=C sort -t: -k2 \
+| sed -e 's/^(none)://; /\.(none)$/d; s/^/ /' >> "$BUILDINFO"
+
+printf
Koji has a similar build environment record, though it's stored in the Koji
database rather than as a file. We do archive environment artifacts from Mock
with builds too, though.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on
@woju commented on this pull request.
> +
+mkdir -p "$BUILDINFO_DIR"
+
+cat > "$BUILDINFO" <> "$BUILDINFO"
If you really insist on a different format for RPM, I'd suggest the file suffix
be changed to something else than `.buildinfo` (maybe `.rpmbuildinfo`?). This
will at least make
@woju commented on this pull request.
> +Format: 1.0-rpm
+Build-Architecture: $(uname -m)
+Source: $RPM_PACKAGE_NAME
+Epoch: $RPM_PACKAGE_EPOCH
+Version: ${RPM_PACKAGE_VERSION}
+Release: ${RPM_PACKAGE_RELEASE}
+Architecture: $RPM_ARCH
+Build-Origin: $(getos)
+Build-Path: $RPM_BUILD_DIR
> I
Interested in something like this for openSUSE. We already have something
comparable called `_buildenv` (XML) e.g. in
https://build.opensuse.org/package/binaries/openSUSE:Factory/bash/standard -
but that is created on the obs_worker level.
@fepitre commented on this pull request.
> +
+mkdir -p "$BUILDINFO_DIR"
+
+cat > "$BUILDINFO" <> "$BUILDINFO"
@Conan-Kudo thank you for your feedback and comments. Generally I would have
loved to have a generic format not being one distro specific to ease
manipulating this file among several
@bmwiedemann do you have some feedback to give from several comments here? As
you work on reproducible builds for openSUSE you are certainly interested by
this new feature.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@fepitre commented on this pull request.
> +
+printf 'Installed-Build-Depends:\n' >> "$BUILDINFO"
+rpm -qa --queryformat '%{epoch}:%{name}-%{version}-%{release}.%{arch}\n' \
+| LC_ALL=C sort -t: -k2 \
+| sed -e 's/^(none)://; /\.(none)$/d; s/^/ /' >> "$BUILDINFO"
+
+printf
@voxik commented on this pull request.
> +
+printf 'Installed-Build-Depends:\n' >> "$BUILDINFO"
+rpm -qa --queryformat '%{epoch}:%{name}-%{version}-%{release}.%{arch}\n' \
+| LC_ALL=C sort -t: -k2 \
+| sed -e 's/^(none)://; /\.(none)$/d; s/^/ /' >> "$BUILDINFO"
+
+printf
@Conan-Kudo commented on this pull request.
> +Format: 1.0-rpm
+Build-Architecture: $(uname -m)
+Source: $RPM_PACKAGE_NAME
+Epoch: $RPM_PACKAGE_EPOCH
+Version: ${RPM_PACKAGE_VERSION}
+Release: ${RPM_PACKAGE_RELEASE}
+Architecture: $RPM_ARCH
+Build-Origin: $(getos)
+Build-Path: $RPM_BUILD_DIR
@Conan-Kudo commented on this pull request.
> +
+mkdir -p "$BUILDINFO_DIR"
+
+cat > "$BUILDINFO" <> "$BUILDINFO"
And I'd rather not have Debian-isms in here.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@woju commented on this pull request.
> +
+mkdir -p "$BUILDINFO_DIR"
+
+cat > "$BUILDINFO" <> "$BUILDINFO"
Again, that's debianism
@woju commented on this pull request.
> +Format: 1.0-rpm
+Build-Architecture: $(uname -m)
+Source: $RPM_PACKAGE_NAME
+Epoch: $RPM_PACKAGE_EPOCH
+Version: ${RPM_PACKAGE_VERSION}
+Release: ${RPM_PACKAGE_RELEASE}
+Architecture: $RPM_ARCH
+Build-Origin: $(getos)
+Build-Path: $RPM_BUILD_DIR
>
@Conan-Kudo requested changes on this pull request.
> +Format: 1.0-rpm
+Build-Architecture: $(uname -m)
+Source: $RPM_PACKAGE_NAME
+Epoch: $RPM_PACKAGE_EPOCH
+Version: ${RPM_PACKAGE_VERSION}
+Release: ${RPM_PACKAGE_RELEASE}
+Architecture: $RPM_ARCH
+Build-Origin: $(getos)
+Build-Path:
@DemiMarie requested changes on this pull request.
Avoid using “whitelist” and properly quote variables containing special
characters
> +cat > "$BUILDINFO" < "$BUILDINFO"
```
This ensures that we properly abort on errors.
> +rpm -qa --queryformat
> So start by explaining what problem you're trying to solve, and not how other
> people might've chosen to solve it.
The purpose of having an automatically generated subpackage `buildinfo` is to
have an exact description of the build environment used to obtain RPMs from a
spec file.
Having
If you want feedback here, you should explain what it is and why we should
care. Outside references are okay for additional background, but the what it
does and why (as in rationale for the whole) needs to be explained right here
so that it can be discussed.
--
You are receiving this because
Just a little ping here to know if anyone has already take a look on the global
form for this. @Conan-Kudo any feedback if you have time? Thank you very much.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
TODO:
- Add Binary field with all built RPMs package names
- Add Checksums for at least source RPM
- Add additional rpm macros (--define, --with/--without, etc.)
Reference: https://wiki.debian.org/ReproducibleBuilds/BuildinfoFiles, Thread
Reproducible builds on Fedora devel list.
You can view,
34 matches
Mail list logo
