Re: [Rpm-maint] [rpm-software-management/rpm] Allow signing with ECDSA keys (PR #3034)

2024-04-16 Thread Panu Matilainen
Merged #3034 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3034#event-12482993321 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Allow signing with ECDSA keys (PR #3034)

2024-04-16 Thread Panu Matilainen
Excellent, thanks! -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3034#issuecomment-2058321276 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Allow signing with ECDSA keys (PR #3034)

2024-04-15 Thread Michael Schroeder
Ok, done. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3034#issuecomment-2056819462 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Allow signing with ECDSA keys (PR #3034)

2024-04-15 Thread Michael Schroeder
@mlschroe pushed 1 commit. 2e3cf5f4629a6f3372451dabe35b58fdf69692bd Add testcases for Ed25519 and NIST P-256 -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/3034/files/a7a9a1df6f972282d472bf58ea0d89895f0a30a6..2e3cf5f4629a6f3372451dabe35b58fdf69692bd You are

Re: [Rpm-maint] [rpm-software-management/rpm] Allow signing with ECDSA keys (PR #3034)

2024-04-15 Thread Michael Schroeder
I can add both an ed25519 and an nist p-256 key test. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3034#issuecomment-2056750547 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Allow signing with ECDSA keys (PR #3034)

2024-04-15 Thread Panu Matilainen
Clearly it's Monday - took me a few moments to see the difference to https://github.com/rpm-software-management/rpm/commit/23770e1a4f28c56a31fe600cae332c77333b60b6 :sweat_smile: I'd be wary of adding any default rule there but clearly ECDSA belongs to DSA as much as EDDSA does, no objection

Re: [Rpm-maint] [rpm-software-management/rpm] Allow signing with ECDSA keys (PR #3034)

2024-04-12 Thread Michael Schroeder
Maybe we should put all unknown algorithms into the DSA slots. I think the distinction was just done so that very old rpm versions didn't trip when they saw a non-rsa signature. Another reason could have been to allow both signing with the old RSA/MD5 (for compat reasons) and the new DSA/SHA1

Re: [Rpm-maint] [rpm-software-management/rpm] Allow signing with ECDSA keys (PR #3034)

2024-04-12 Thread Michael Schroeder
See also 23770e1a4f28c56a31fe600cae332c77333b60b6 -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/3034#issuecomment-2051692148 You are receiving this because you are subscribed to this thread. Message ID:

[Rpm-maint] [rpm-software-management/rpm] Allow signing with ECDSA keys (PR #3034)

2024-04-12 Thread Michael Schroeder
Key import and verification already works, its just that rpm does not know where to put the signature. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/3034 -- Commit Summary -- * Allow signing with ECDSA keys -- File