Re: [Rpm-maint] [rpm-software-management/rpm] Be much more careful about copying data from the signature header (#1577)

2021-03-16 Thread Panu Matilainen
Merged #1577 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1577#event-4463707057___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Be much more careful about copying data from the signature header (#1577)

2021-03-16 Thread Panu Matilainen
Mind you, the suggested optimization to avoid multiple sorts totally makes sense and never occurred to me at all (too much staring at how it always did it), so thanks for that! Just that with critical fixes needing backports and all, other enhancements such as performance are best kept apart -

Re: [Rpm-maint] [rpm-software-management/rpm] Be much more careful about copying data from the signature header (#1577)

2021-03-16 Thread Panu Matilainen
> I included a couple of minor performance suggestions, but those should not > delay merging. But that's exactly what such things tend to do, as I'm now wondering could there be some quirks code, especially very old versions, that cause it to actually rely on the put-sort cycle. It's extremely

Re: [Rpm-maint] [rpm-software-management/rpm] Be much more careful about copying data from the signature header (#1577)

2021-03-15 Thread Panu Matilainen
(reporter credits added to commit message) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1577#issuecomment-799312095___

[Rpm-maint] [rpm-software-management/rpm] Be much more careful about copying data from the signature header (#1577)

2021-03-15 Thread Panu Matilainen
Only look for known tags, and ensure correct type and size where known before copying over. Bump the old arbitrary 16k count limit to 16M limit though, its not inconceivable that a package could have that many files. While at it, ensure none of these tags exist in the main header, which would