Re: [Rpm-maint] [rpm-software-management/rpm] Check that count won't overflow (#1493)

2021-02-17 Thread Demi Marie Obenour
@pmatilai The real purpose of this check is to prevent overflows in `dataLength`. Would a check there be okay? Or would it be better to use `__builtin_mul_overflow`? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Check that count won't overflow (#1493)

2021-01-14 Thread Panu Matilainen
Closed #1493. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1493#event-4205564323___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Check that count won't overflow (#1493)

2021-01-14 Thread Panu Matilainen
NAK. This is actually an entirely useless check (the existing one in regionSwab() equally so) as it misses the real limit by such a *huge* margin, yet gives you a false sense of security from doing yet another check. The one count-related thing we can check straight away is that it has to be

[Rpm-maint] [rpm-software-management/rpm] Check that count won't overflow (#1493)

2021-01-13 Thread Demi Marie Obenour
This is already checked in regionSwab() but it is better to check it earlier, in case someone uses hdrblobInit() without hdrblobImport(). You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1493 -- Commit Summary -- * Check