Oh btw, when submitting a PR with an associated ticket, it's useful to put
"Closes: #" into the commit message to get the ticket automatically
closed when the PR is merged. Saves that little bit of administrative trivia
clickety-click.
--
You are receiving this because you are subscribed to th
Merged #737 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/737#event-2390571644___
Rpm-maint mailing list
Rpm-maint
pmatilai approved this pull request.
Looking fine now.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/737#pullrequestreview-245886981
The commit message should be a bit more precise. The condition is actually
correct. It's just using a sub optimal style.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/737
pmatilai commented on this pull request.
It might be implemented internally in bash, but generally speaking "[" is an
external command (try 'ls -l /bin/[') and needs to be surrounded by space, and
even in bash it's common good style anyway (see elsewhere in the script). Shell
coding style diffe
Introduced in commit 1da9e83, spotted by covscan.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/737
-- Commit Summary --
* Fix bogus if-condition in find-debuginfo.sh (#735)
-- File Changes --
M scripts/find-debuginf
