If you look at the real commit messages, it's quite different to how GH renders
it. The long commit hashes just don't align very nicely at < 78 characters per
line.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Merged #816 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/816#event-2565729934___
Rpm-maint mailing list
The alignment of the commit message is broken otherwise the patch looks perfect.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
I don't know how to reproduce the rust stuff, but %prep failing does stop the
build.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Didn't mention it originally because it's not a single commit and easily found
by the "parseLines" reference, but commit range added now.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
The patch is correct. The only thing that I propose to change is to is to
refer to the particular commit behind the regression.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
pmatilai commented on this pull request.
> @@ -65,6 +65,7 @@ EXTRA_DIST += data/SPECS/symlinktest.spec
EXTRA_DIST += data/SPECS/deptest.spec
EXTRA_DIST += data/SPECS/verifyscript.spec
EXTRA_DIST += data/SPECS/fakeshell.spec
+EXTRA_DIST += data/SPECS/mini.spec
So it seems...
--
You are
ignatenkobrain commented on this pull request.
> @@ -65,6 +65,7 @@ EXTRA_DIST += data/SPECS/symlinktest.spec
EXTRA_DIST += data/SPECS/deptest.spec
EXTRA_DIST += data/SPECS/verifyscript.spec
EXTRA_DIST += data/SPECS/fakeshell.spec
+EXTRA_DIST += data/SPECS/mini.spec
didn't you forgot to
More ripples from the parseLines() unification, the callers used to
explicitly allocate an empty string buffer, but with lazy allocation
from parseLines() they're getting NULL in the special circumstance of
being last in the spec, and no "body". Specifically this happens with
empty %description or
