Re: [Rpm-maint] [rpm-software-management/rpm] Forbid headers with only a region (#1495)

2021-02-19 Thread Demi Marie Obenour
Closed #1495. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1495#event-4351140494___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] Forbid headers with only a region (#1495)

2021-01-19 Thread Panu Matilainen
Oh, right, I'd forgotten about that. That existing check is wrong in it's current habitat, it got moved around in the last big refactoring. A header is fundamentally nothing but an abstract data container, and being empty is an entirely valid condition for it to be in. -- You are receiving

Re: [Rpm-maint] [rpm-software-management/rpm] Forbid headers with only a region (#1495)

2021-01-16 Thread Demi Marie Obenour
We actually already reject empty headers (with no tags at all) in `hdrblobVerifyRegion`. So the only question remaining is if an empty region (`ril == 0`) is valid. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Forbid headers with only a region (#1495)

2021-01-14 Thread Panu Matilainen
It's entirely legitimate for a *header* to be empty, region or no. A *package* cannot have an empty header (or region), but that'd be a different kind of check. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Rpm-maint] [rpm-software-management/rpm] Forbid headers with only a region (#1495)

2021-01-13 Thread Demi Marie Obenour
Such headers are useless and might cause problems elsewhere. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1495 -- Commit Summary -- * Forbid headers with only a region -- File Changes -- M lib/header.c (6) --