Works for me.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/830#issuecomment-529891374___
Rpm-maint mailing list
Merged #830 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/830#event-2621887065___
Rpm-maint mailing list
The comments are incorporated in the new version.
Thank you for the review.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@pavlinamv pushed 2 commits.
db00406d78149cfaa0e78fea9426d5642bc6a95e Improve description of conditionals
in spec documentation
c150103aae26475d92ee26d6427a13f9f21890ad Add description of comments in spec
documentation
--
You are receiving this because you are subscribed to this thread.
pmatilai commented on this pull request.
> +%elifarch, %elifos or %else can be optionally used. Conditionals %endif and
+%else should not be followed by any text. Conditionals may be nested within
+other conditionals.
+
+Conditionals are not macros. It has an interesting consequence (similar as
pmatilai commented on this pull request.
> +
+%if can be used for various purposes. The test can be evaluated based on
+the existence of a macro, like:
+\verbatim
+ %if %{defined with_foo} && %{undefined with_bar}
+\endverbatim
+string comparison:
+\verbatim
+ %if %{optimize_flags}
pmatilai commented on this pull request.
> %endif
\endverbatim
-Conditionals are not macros, thus they can be used in spec files only.
+%ifos is used to control RPM's spec file processing according to the
+build system's operating system.
+
+%if can be used for various purposes. The
pmatilai commented on this pull request.
> %endif
\endverbatim
-Conditionals are not macros, thus they can be used in spec files only.
+%ifos is used to control RPM's spec file processing according to the
+build system's operating system.
It's not build system's operating system, but
pmatilai commented on this pull request.
> \verbatim
- %ifarch ppc64 ppc x86_64
- ...
- %if 0%{?ver} && 0%{?ver} >= 100
- ...
- %else
- ...
- %endif
+ %ifarch %{power64} s390x x86_64 ia64
+ %global architectures 1
The new example is just
pmatilai commented on this pull request.
> @@ -214,24 +214,67 @@ can express this as
BuildConflicts: gcc <= 2.7.2.1
\endverbatim
+\section comments Comments
+
+Comments in spec file have # at the start of the line.
+\verbatim
+ # this is a comment
+\endverbatim
+Macros are
- Improve description of conditionals in spec documentation
- Add description of comments in spec documentation
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/830
-- Commit Summary --
* Improve description of conditionals
11 matches
Mail list logo
