Merged #810 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/810#event-2572687837___
Rpm-maint mailing list
The checks are failing due to not rebasing to get the "rawhide workaround" in
place.
The commit message is still unnecessarily hard to read but I give up.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
The commit message is changed according to the review.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
When pushing updates to address comments, make a note of what you changed here.
It's not always that obvious, and pushes without comments go easily unnoticed
overall.
""Prefer '[] && []' to '[ -a ]' and '[] || []' to '[ -o ]'" describes the
literal change done by the patch. This is not useful
The change might be fine as such, but the summary is unreadable and overall the
message largely fails to explain *why* should one syntax be preferred over
another one. "Because covscan" is not a proper reason.
test(1) man page gives a clue:
```
NOTE: Binary -a and -o are inherently ambiguous.
It corrects warnings [SC2166] spotted by covscan:
warning: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. [SC2166]
warning: Prefer [ p ] || [ q ] as [ p -o q ] is not well defined. [SC2166]
Motivated by last the comment in #802. This should fix all [sc2166] warnings
spotted by covscan
