> See #1783 (sorry, this was way more fun than what I'm supposed to be doing...)
what is that?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
I'll adjust this to use the new macro as soon as it is upstream.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
See #1783
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1781#issuecomment-924829127___
Rpm-maint mailing list
> A macro will always see the macro expanded version of the parameter. Not sure
> if there is a way around that with the current macro system - especially as
> one needs to expand %{PATCH5} or what every hold the data in question at some
> point.
Macro arguments are expanded yes, but you need
Yes, we need quoting at more places. Reopened #1644.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Not sure if we can do a quoting macro. This patch has the benefit of running in
lua and though work on the original content of the file name. A macro will
always see the macro expanded version of the parameter. Not sure if there is a
way around that with the current macro system - especially as
Adding the single quotes seems like a no-brainer on the outset, but when you
need to escape them, it opens a different can of worms: macro use is not
limited to shell, only there's no way to tell (rhymes nicely, no? :laughing: )
and can occur outside the spec as well (the number of backslashes
@DemiMarie commented on this pull request.
> + print("'"..string.gsub(p, "'", "'''").."'".." ") end}
+%sources %{lua: for i, s in ipairs(sources) do \
+ print("'"..string.gsub(s, "'", "'''").."'".." ") end}
```suggestion
print("'"..string.gsub(p, "'", "'''").."' ") end}
by enclosing them in single quotes ().
Replace sigle quotes within with \ as needed for sh
Resolves: #1445
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/1781
-- Commit Summary --
*
