Re: [Rpm-maint] [rpm-software-management/rpm] Raise an error when passing arguments to non-parametric macros (PR #2940)

2024-03-06 Thread Panu Matilainen
(updated the commit message to reflect error -> warning change) -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2940#issuecomment-1980694996 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Raise an error when passing arguments to non-parametric macros (PR #2940)

2024-03-05 Thread Panu Matilainen
%{zzz foo} handled now, totally forgot that one... I do think it should be an error just like it is on builtins, but noticed that in the ticket this is something you stumbled on in the wild, so we can make it a warning for a while and later turn it into an error. So, warning it is for now. --

Re: [Rpm-maint] [rpm-software-management/rpm] Raise an error when passing arguments to non-parametric macros (PR #2940)

2024-02-28 Thread Michael Schroeder
Maybe a warning would be less intrusive. (And what about `%{zzz foo}`?) -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2940#issuecomment-1969148570 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Raise an error when passing arguments to non-parametric macros (PR #2940)

2024-02-28 Thread Panu Matilainen
@mlschroe I know you closed the ticket already but this seems like the right thing to do... Or does this actually break some odd case that I'm not aware of? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2940#issuecomment-1968873107 You

[Rpm-maint] [rpm-software-management/rpm] Raise an error when passing arguments to non-parametric macros (PR #2940)

2024-02-28 Thread Panu Matilainen
Fixes: #2932 You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/2940 -- Commit Summary -- * Raise an error when passing arguments to non-parametric macros -- File Changes -- M rpmio/macro.c (5) M tests/rpmmacro.at