It should be safe from the db POV to remove this now, yes. However to me this
is only a part of a bigger change to remove the associated and now unnecessary
signal queue from rpm API and ABI, and there's not a whole lot benefit in doing
this part without doing the others (the whole rpm*Rock trac
Closed #1667.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1667#event-4884044359___
Rpm-maint mailing list
Rpm-maint@lists.rpm
@Conan-Kudo approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1667#pullrequestreview-682454021___
R
AFACT ndb does not need this. It should be self-healing (and I did write a
torture test program to test this).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1667#issuecom
This seems related to
https://github.com/rpm-software-management/rpm/commit/56f49d7f5af7c1c8a3eb478431356195adbfdd25
- in rpm-ostree for example the atomicity of the rpmdb is also done alongside
the filesystem too - if we don't have a `SIGINT` handler then we shouldn't have
an `atexit` handler
So I guess then, the question would be to @mlschroe if NDB still needs this?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1667#issuecomment-848991740_
> I'm not sure we can do that, because the point of this handler is to ensure
> the rpmdb is sane in those scenarios.
There are two problems with this approach:
1. We need to make sure the rpmdb is reasonable even if RPM dies with SIGKILL.
So the atexit handler cannot be essential for correctn
I'm not sure we can do that, because the point of this handler is to ensure the
rpmdb is sane in those scenarios.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1667#issue
It causes undefined behavior in multithreaded programs.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/1667
-- Commit Summary --
* Rip out the atexit handler
-- File Changes --
M lib/misc.h (3)
M lib/rpmdb.c (16)
