As most of these changes are incorporated into the original PR I am closing
this one.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Closed #1066.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1066#event-3046235283___
Rpm-maint mailing list
pmatilai commented on this pull request.
>
# Set to 1 to flush file IO during transactions (at a severe cost in
-# performance for rotational disks)
-#%_flush_io0
+# performance for rotational disks). Set to -1 for enabling when running on
+# SSDs. Set to 0 for always off.
+%_flush_io
pmatilai commented on this pull request.
> + rpmPushMacro(NULL, "_minimize_writes", NULL, "1", 0);
+ } else {
+ char * val = rpmExpand("%{_minimize_writes}", NULL);
+ rpmPushMacro(NULL, "_minimize_writes", NULL, val, 0);
+ _free(val);
+ }
+
pmatilai commented on this pull request.
> @@ -745,12 +745,14 @@ package or when debugging this package.\
%_pkgverify_flags 0x0
# Set to 1 to minimize writing (at the cost of more reads) to
-# conserve eg SSD disks.
-%_minimize_writes 0
+# conserve eg SSD disks. Set to -1 for enabling
This is a take on #949 as described in
https://github.com/rpm-software-management/rpm/pull/949#issuecomment-580354653
Original Patch is rebased to have access to the new rpmMacroIsDefined()
function.
Patches should probably be squashed before merging. Keeped them separate to
make review easier.
