Re: [Rpm-maint] [rpm-software-management/rpm] Validate Buildsystem definitions, error out on unknown (PR #2956)

2024-03-14 Thread Florian Festi
Merged #2956 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2956#event-12117552701 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Validate Buildsystem definitions, error out on unknown (PR #2956)

2024-03-14 Thread Panu Matilainen
Rebased to get the ASLR workaround. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2956#issuecomment-1997344064 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] Validate Buildsystem definitions, error out on unknown (PR #2956)

2024-03-14 Thread Panu Matilainen
Okay, it now emits a debug message such as > D: required parametric macro %buildsystem_fubar_conf not defined buildsystem > fubar -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2956#issuecomment-1997044375 You are receiving this

Re: [Rpm-maint] [rpm-software-management/rpm] Validate Buildsystem definitions, error out on unknown (PR #2956)

2024-03-14 Thread Panu Matilainen
@pmatilai pushed 3 commits. 729a5f1cf52c5129771ab1f1164c9926174ca0bb Validate Buildsystem definitions, error out on unknown 1854bdee7e14d7c4058780fdad16449326af553f Fix more Buildsystem related leaks, sigh ac76406a39a6dabd09d071eecb4c8ddcc92a550c Drop manual macro invocation from the

Re: [Rpm-maint] [rpm-software-management/rpm] Validate Buildsystem definitions, error out on unknown (PR #2956)

2024-03-14 Thread Panu Matilainen
Yup, it's something I considered. I can certainly add some debug-level message to help, well, debug when writing these things. I just want the user oriented message to be clear and straight to the point, mumbling about missing sections in that message easily leads you to think this was a user

Re: [Rpm-maint] [rpm-software-management/rpm] Validate Buildsystem definitions, error out on unknown (PR #2956)

2024-03-14 Thread Florian Festi
I wonder if the error message should mention the missing section. The error message is fine for packagers if the build systems are all there already but it is not that helpful if one tries to write one. -- Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] Validate Buildsystem definitions, error out on unknown (PR #2956)

2024-03-11 Thread Panu Matilainen
@pmatilai pushed 1 commit. fc8379379d525fd069d586ce5f0c1d9b0a3a300c Drop manual macro invocation from the buildsystem docs -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2956/files/302f90372bb2599b6ca3e65ff73241866d04cad0..fc8379379d525fd069d586ce5f0c1d9b0a3a300c

Re: [Rpm-maint] [rpm-software-management/rpm] Validate Buildsystem definitions, error out on unknown (PR #2956)

2024-03-11 Thread Panu Matilainen
@pmatilai pushed 1 commit. c250502b7cbc77dbb6a7824ccdcee2a1e09dd22f Fix more Buildsystem related leaks, sigh -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2956/files/1acf96c0e3bc2129f26f0afc123de54341c34fb7..c250502b7cbc77dbb6a7824ccdcee2a1e09dd22f You are

Re: [Rpm-maint] [rpm-software-management/rpm] Validate Buildsystem definitions, error out on unknown (PR #2956)

2024-03-11 Thread Panu Matilainen
Logically this should've been in commit f02ddfd121d91ea00a534a0e04374c478f56d437 of course, but better late than never. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2956#issuecomment-1987968537 You are receiving this because you are

[Rpm-maint] [rpm-software-management/rpm] Validate Buildsystem definitions, error out on unknown (PR #2956)

2024-03-11 Thread Panu Matilainen
Verify all required sections (%conf, %build and %install) are covered by the requested buildsystem, error out with a proper error message if not. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/2956 -- Commit Summary -- *