Re: [Rpm-maint] [rpm-software-management/rpm] When using %autopatch, create backup files with .~ suffix by def… (#109)

Closed #109. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/109#event-927531760___ Rpm-maint mailing list Rpm-maint@lists.rpm.org

Re: [Rpm-maint] [rpm-software-management/rpm] When using %autopatch, create backup files with .~ suffix by def… (#109)

but the quilt backend is probably relying on quirks as it is now, need to look closer. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] When using %autopatch, create backup files with .~ suffix by def… (#109)

Oh, I know about the patches_num patch. I don't much like it, and thought ordinals aren't that helpful. Which is why there are no backups currently. I was kinda hoping you guys had come up with some nicer way to generate backups with patch numbers when I saw this ;) Anyway, on a second thought

Re: [Rpm-maint] [rpm-software-management/rpm] When using %autopatch, create backup files with .~ suffix by def… (#109)

pmatilai requested changes on this pull request. I'm actually in favor of enabling backups by default. However this patch clearly hasn't been tested, nor reviewed, at all. It refers to a non-existent patches_num variable so any attempt to use %autosetup with this patch ends up in: `error: lua

Re: [Rpm-maint] [rpm-software-management/rpm] When using %autopatch, create backup files with .~ suffix by def… (#109)

Taking a closer look at the mageia bug, I notice that the backup files lacks the '~' backup suffix, for which I'd consider this rather a mageia specific shortcoming in their %apply_patches implementation, cooker's not affected by.. The only scare thing about mageia's past use of %apply_patches

Re: [Rpm-maint] [rpm-software-management/rpm] When using %autopatch, create backup files with .~ suffix by def… (#109)

backup files included in packages are nothing but a result of faulty packaging, where disablingdefault non-intrusive functionality of use are clearly not the right solution and really should be considered flawed packaging practices and workarounds rather than correctly addressing and fixing the

Re: [Rpm-maint] [rpm-software-management/rpm] When using %autopatch, create backup files with .~ suffix by def… (#109)

@rpm-maint Please hate @jsilhan and @j-mracek for this -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/109#issuecomment-266035398___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] When using %autopatch, create backup files with .~ suffix by def… (#109)

For those looking from GitHub and the URL is being weirdly borked, here's the bug: https://bugs.mageia.org/show_bug.cgi?id=9832 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] When using %autopatch, create backup files with .~ suffix by def… (#109)

On 9 December 2016 at 15:41, Igor Gnatenko wrote: > @soig Fully agree, saw same problem in Fedora > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub >

Re: [Rpm-maint] [rpm-software-management/rpm] When using %autopatch, create backup files with .~ suffix by def… (#109)

@proyvind @soig @ignatenkobrain Maybe it'd be better if it was not on by default? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] When using %autopatch, create backup files with .~ suffix by def… (#109)

@soig Fully agree, saw same problem in Fedora -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/109#issuecomment-266029269___

Re: [Rpm-maint] [rpm-software-management/rpm] When using %autopatch, create backup files with .~ suffix by def… (#109)

On 9 December 2016 at 04:03, proyvind wrote: > …ault > > The legacy mandriva %apply_patches macro by default generated backup > files with unique suffixes by default, the suffix for patch0 being > .0001~ etc. > > As for those of us still using gendiff, this is still

Re: [Rpm-maint] [rpm-software-management/rpm] When using %autopatch, create backup files with .~ suffix by def… (#109)

Can one of the admins verify this patch? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/109#issuecomment-266029013___ Rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] When using %autopatch, create backup files with .~ suffix by def… (#109)

Conan-Kudo approved this pull request. Looks good to me. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: