Re: [Rpm-maint] [rpm-software-management/rpm] verifySignature(): package signatures must be PGPSIGTYPE_BINARY (PR #1801)

2021-10-21 Thread Demi Marie Obenour
@DemiMarie commented on this pull request. Thanks for the feedback @pmatilai. > @@ -426,6 +426,11 @@ static int pgpVersion(const uint8_t *h, size_t hlen, > uint8_t *version) return 0; } +int pgpSignatureType(pgpDigParams _digp) { +assert(_digp->tag == PGPTAG_SIGNATURE); That is a

Re: [Rpm-maint] [rpm-software-management/rpm] verifySignature(): package signatures must be PGPSIGTYPE_BINARY (PR #1801)

2021-10-21 Thread Demi Marie Obenour
@DemiMarie pushed 1 commit. 17c93c31eceed4cd9a3e78385756f4804c047f50 verifySignature(): package signatures must be PGPSIGTYPE_BINARY -- You are receiving this because you are subscribed to this thread. View it on GitHub:

Re: [Rpm-maint] [rpm-software-management/rpm] verifySignature(): package signatures must be PGPSIGTYPE_BINARY (PR #1801)

2021-10-21 Thread Panu Matilainen
@pmatilai commented on this pull request. > @@ -566,7 +566,9 @@ static rpmRC verifyDigest(struct rpmsinfo_s *sinfo) static rpmRC verifySignature(rpmKeyring keyring, struct rpmsinfo_s *sinfo) { -rpmRC res = rpmKeyringVerifySig(keyring, sinfo->sig, sinfo->ctx); +rpmRC res = RPMRC_FAIL;

Re: [Rpm-maint] [rpm-software-management/rpm] verifySignature(): package signatures must be PGPSIGTYPE_BINARY (PR #1801)

2021-10-21 Thread Panu Matilainen
@pmatilai commented on this pull request. > @@ -426,6 +426,11 @@ static int pgpVersion(const uint8_t *h, size_t hlen, > uint8_t *version) return 0; } +int pgpSignatureType(pgpDigParams _digp) { +assert(_digp->tag == PGPTAG_SIGNATURE); Imagine for a moment what life would be like

Re: [Rpm-maint] [rpm-software-management/rpm] verifySignature(): package signatures must be PGPSIGTYPE_BINARY (PR #1801)

2021-10-19 Thread Demi Marie Obenour
@DemiMarie pushed 1 commit. f4521694942624460c7238eb7e61a52f290e35cc verifySignature(): package signatures must be PGPSIGTYPE_BINARY -- You are receiving this because you are subscribed to this thread. View it on GitHub:

[Rpm-maint] [rpm-software-management/rpm] verifySignature(): package signatures must be PGPSIGTYPE_BINARY (PR #1801)

2021-10-19 Thread Demi Marie Obenour
RPM packages are binary documents and must be signed as such. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1801 -- Commit Summary -- *