hroncok commented on this pull request.
> @@ -178,8 +178,10 @@
depsextras.remove(dep)
deps = depsextras
# console_scripts/gui_scripts entry points need pkg_resources from
setuptools
-if
gordonmessmer commented on this pull request.
> @@ -178,8 +178,10 @@
depsextras.remove(dep)
deps = depsextras
# console_scripts/gui_scripts entry points need pkg_resources from
setuptools
-if
hroncok commented on this pull request.
Damn GitHub reviews, this comment was hanging here for 23 days. Sorry about
that.
> @@ -178,8 +178,10 @@
depsextras.remove(dep)
deps = depsextras
# console_scripts/gui_scripts entry points need
Merged #973 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/973#event-2877143123___
Rpm-maint mailing list
Pretty straight forward.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/973#issuecomment-564917888___
Rpm-maint mailing list
Conan-Kudo approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/973#pullrequestreview-329214227___
LGTM. @hroncok r?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/973#issuecomment-563426375___
Rpm-maint mailing list
scripts/pythondistdeps: Only add setuptools requirement for egg-info packages.
This should address issue #954
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/973
-- Commit Summary --
* scripts/pythondistdeps: Only add
