@ignatenkobrain pushed 2 commits.
26410a6 build: make haveRichDep aware of other fields allowed to have them
998c1b8 build: check rich dependencies for special characters
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
Hmm, I just noticed that haveTildeDep/haveCharInDep does not work for rich
dependencies...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@mlschroe Well, when we're referring to hg/git/svn snapshot dates, that's
considered as part of upstream versioning. This is done in openSUSE and we want
to move to that in Fedora to simplify automation of package (re)builds and
things like that.
--
You are receiving this because you are
@mlschroe, would you mind implementing this in libsolv? Or should I do so?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
I don't mind having this, '^' should not break existing EVR uses.
I'm a bit uncertain about the use case, wouldn't you put the '20160101' from
the example in the release? 'Version' usually comes from upstream and 'Release'
comes from the packager.
But, as said, I'm not opposed ;-)
--
You are
keszybz commented on this pull request.
Nice!
> @@ -45,6 +45,20 @@ int rpmvercmp(const char * a, const char * b)
continue;
}
+ /*
+* Handle caret separator. Concept is same as tilde, except if one of
+* strings ends (base version), another considered
Conan-Kudo approved this pull request.
The changes look good, but here's a suggestion for the function name change.
> @@ -228,12 +228,12 @@ static rpmRC processScriptFiles(rpmSpec spec, Package
> pkg)
return rc;
}
-static int haveTildeDep(Package pkg)
+static int haveCharInDep(Package
Conan-Kudo approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/597#pullrequestreview-175803053___
@ffesti @ignatenkobrain Let's have a clearer name for the function, please?
Char does not mean carat to me. :)
EDIT: I'm dumb. This is a generalization of the tilde function.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@ffesti @ignatenkobrain Let's have a clearer name for the function, please?
`Char` does not mean `carat` to me. :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Sounds good to me. ^ is a nice character for this.
haveCharInDep() is not a great name for the function, but meh...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Like noted in #88, I'm not opposed. Symmetry usually makes sense, and if
there's a way to force sorting one way then why not the other? Especially since
there clearly is a technical case for it too.
@mlschroe , thoughts?
--
You are receiving this because you are subscribed to this thread.
pmatilai commented on this pull request.
> (void) rpmlibNeedsFeature(pkg, "TildeInVersions", "4.10.0-1");
+/* check if the package has a dependency with a '^' */
+if (haveCharInDep(pkg, '^'))
+ (void) rpmlibNeedsFeature(pkg, "CaretInVersions", "4.14.0-1");
The version in
ignatenkobrain commented on this pull request.
> (void) rpmlibNeedsFeature(pkg, "TildeInVersions", "4.10.0-1");
+/* check if the package has a dependency with a '^' */
+if (haveCharInDep(pkg, '^'))
+ (void) rpmlibNeedsFeature(pkg, "CaretInVersions", "4.14.0-1");
not sure
@pmatilai @hroncok @jasontibbitts @Conan-Kudo
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/597#issuecomment-439326683___
15 matches
Mail list logo
