Re: [Rpm-maint] [rpm-software-management/rpm] Compress annobin notes (#751)

2019-06-19 Thread Panu Matilainen
Merged #751 into master. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/751#event-2423869845___ Rpm-maint mailing list Rpm-maint@lists.rpm.org

Re: [Rpm-maint] [rpm-software-management/rpm] Compress annobin notes (#751)

2019-06-19 Thread Panu Matilainen
pmatilai approved this pull request. Much better, thanks. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/751#pullrequestreview-251642515___

Re: [Rpm-maint] [rpm-software-management/rpm] Compress annobin notes (#751)

2019-06-17 Thread nickclifton
Hi Colin, > Can you keep the commit message title to < 80 chars? And move the text from > the PR description into the commit message as well. Sorry about that, I will remember for next time. > Seems OK to me but: why don't the compilers do this by default? Because at the time that the notes

Re: [Rpm-maint] [rpm-software-management/rpm] Compress annobin notes (#751)

2019-06-17 Thread nickclifton
Hi Mark, > I don't think this should be part of add_minidebug (). It is something > that would need to happen even if we don't run add_minidebug (). Also > add_minidebug () runs after stripping/splitting the main ELF file into > a .debug file (which also gets a copy of all notes). > > I noticed

Re: [Rpm-maint] [rpm-software-management/rpm] Compress annobin notes (#751)

2019-06-17 Thread Mark Wielaard
Hi Nick, On Fri, 2019-06-14 at 09:29 -0700, nickclifton wrote: > This is a request to add support for compressing annobin notes found > in executable binaries built on Fedora and RHEL systems. > > The annobin project adds a note section to binary files describing > the security hardening

Re: [Rpm-maint] [rpm-software-management/rpm] Compress annobin notes (#751)

2019-06-14 Thread Colin Walters
Can you keep the commit message title to < 80 chars? And move the text from the PR description into the commit message as well. Seems OK to me but: why don't the compilers do this by default? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or