Thanks for merging it :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/984#issuecomment-574159110___
Rpm-maint mailing list
Closed #984.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/984#event-2946531080___
Rpm-maint mailing list
Merged via #1006 . Thanks for the effort of bringing this upstream.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@KOLANICH pushed 1 commit.
9987dd701e3351e7e6304f7753fb6d6f0a7484e9 /scripts/check-rpaths: Do not use
bashism. (DebBug:772404)
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
Yes, the patch URL is uninteresting and irrelevant, a link to the *bug* would
be relevant. Also the "original message" and quotation just makes it
unnecessarily strange. Just do as @Conan-Kudo requested in
https://github.com/rpm-software-management/rpm/pull/984#issuecomment-570160992,
thanks.
@KOLANICH I'd rather you use the Debian bug reference than the patch URL. We
_have_ the patch, after all.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@KOLANICH pushed 1 commit.
6be64508deb6f79f9daa82f316e2fd13fac725f1 /scripts/check-rpaths: Do not use
bashism.
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
Yup, commit messages must be self-contained. Providing external links for
additional background data such as originating bug report is fine, but not
sufficient.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@KOLANICH That's really not the point. And webarchive systems do not
necessarily have this indexed.
The correct thing to do here would be to change the commit to have relevant
information:
```
$ git commit --amend --author="Michal Čihař " --date="Tue, 30
Dec 2014 11:55:15 +0100"
```
With the
>it'll be a dead link if this is merged.
There is a backup on WebArchive now. We all know that if we see a dead link we
should check WebArchive for it :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@KOLANICH pushed 3 commits.
4c7323f69b4fddf928245e9db2d1c9ca9b277ef2 Fix building with no BerkeleyDB
support
166c6c5a1e066bd485f3be98feb5935b1b050f3a Move db_descr assignment from rpmdb
to dbi
17645a87842f6f478d01bebf1c0c1e827e8db4c6 Do not use bashism for gettext
--
You are receiving
@KOLANICH I'd rather have the link to the Debian patch file removed from the
commit message. It's not particularly important...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
ignatenkobrain approved this pull request.
LGTM
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Even though the commit message looks like this (it have been inherited from the
patch file) I don't see this patch removing any calls. I can guess that the
most of the patch got missing (already merged?) but the text haven't been
changed.
--
You are receiving this because you are subscribed
It'd probably be better to use a POSIX sh-compatible way to use gettext instead
of straight up dropping internationalization capability.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
15 matches
Mail list logo
