Oh and to clarify, what I mean by "getting into OpenPGP" is at least try to get
a reservation for the algorithm(s). There are any number of such reservations
in the RFC and one would think that it wouldn't require jumping through *too*
many hoops.
--
You are receiving this because you are
What I meant by detaching is declare a separate RPMHASHALGO_FOO enumeration
that is free of PGP constraints and then adjust the entire codebase to use that
as appropriate, but that seems like quite a bit of busywork and churn.
Please try to get GOST included in OpenPGP officially, that's what
> RPM 5 did it: https://abf.io/soft/rpm5/blob/master/rpmio/rpmiotypes.h#lc-204
> Will the same approach be acceptable in rpm4?
Well, rpm5 compatibility is an explicit _non-goal_, so it's not likely to sway
anyone on this...
--
You are receiving this because you are subscribed to this thread.
RPM 5 did it: https://abf.io/soft/rpm5/blob/master/rpmio/rpmiotypes.h#lc-204
Will the same approach be acceptable in rpm4?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
> The other option would be detaching the digest algorithm enumeration used by
> rpm for non-PGP purposes from the OpenPGP values
If to make values out of the range specified by the OpenPGP RFC (e.g. 250 and
251 or whatever else), they will still be called `PGPHASHALGO_*`, but may it
break
pmatilai requested changes on this pull request.
Please ask for at least a reservation for the GOST algorithms in OpenPGP RFC, I
don't see this being acceptable otherwise.
The other option would be detaching the digest algorithm enumeration used by
rpm for non-PGP purposes from the OpenPGP
pmatilai commented on this pull request.
> @@ -1229,6 +1229,17 @@ static const struct rpmlibProvides_s rpmlibProvides[]
> = {
{ "rpmlib(FileDigests)", "4.6.0-1",
(RPMSENSE_EQUAL),
N_("file digest algorithm is per package configurable") },
+#ifdef
StZhukov commented on this pull request.
> @@ -1229,6 +1229,17 @@ static const struct rpmlibProvides_s rpmlibProvides[]
> = {
{ "rpmlib(FileDigests)", "4.6.0-1",
(RPMSENSE_EQUAL),
N_("file digest algorithm is per package configurable") },
+#ifdef
StZhukov commented on this pull request.
> @@ -395,6 +395,7 @@ AC_SUBST(WITH_OPENSSL_LIB)
WITH_LIBGCRYPT_INCLUDE=
WITH_LIBGCRYPT_LIB=
if test "$with_crypto" = libgcrypt ; then
+ AC_DEFINE(WITH_LIBGCRYPT, 1, [Build with libgcrypt instead of nss3 support?])
Thanks, I will change.
--
You
mlschroe commented on this pull request.
> @@ -266,6 +266,8 @@ typedef enum pgpHashAlgo_e {
PGPHASHALGO_SHA384 = 9, /*!< SHA384 */
PGPHASHALGO_SHA512 = 10, /*!< SHA512 */
PGPHASHALGO_SHA224 = 11, /*!< SHA224 */
+PGPHASHALGO_GOST12_256 = 100,
mikhailnov commented on this pull request.
> @@ -266,6 +266,8 @@ typedef enum pgpHashAlgo_e {
PGPHASHALGO_SHA384 = 9, /*!< SHA384 */
PGPHASHALGO_SHA512 = 10, /*!< SHA512 */
PGPHASHALGO_SHA224 = 11, /*!< SHA224 */
+PGPHASHALGO_GOST12_256 =
mlschroe commented on this pull request.
> @@ -266,6 +266,8 @@ typedef enum pgpHashAlgo_e {
PGPHASHALGO_SHA384 = 9, /*!< SHA384 */
PGPHASHALGO_SHA512 = 10, /*!< SHA512 */
PGPHASHALGO_SHA224 = 11, /*!< SHA224 */
+PGPHASHALGO_GOST12_256 = 100,
mlschroe commented on this pull request.
> @@ -266,6 +266,8 @@ typedef enum pgpHashAlgo_e {
PGPHASHALGO_SHA384 = 9, /*!< SHA384 */
PGPHASHALGO_SHA512 = 10, /*!< SHA512 */
PGPHASHALGO_SHA224 = 11, /*!< SHA224 */
+PGPHASHALGO_GOST12_256 = 100,
Conan-Kudo requested changes on this pull request.
It's a good first start, just some initial nits...
> @@ -395,6 +395,7 @@ AC_SUBST(WITH_OPENSSL_LIB)
WITH_LIBGCRYPT_INCLUDE=
WITH_LIBGCRYPT_LIB=
if test "$with_crypto" = libgcrypt ; then
+ AC_DEFINE(WITH_LIBGCRYPT, 1, [Build with libgcrypt
14 matches
Mail list logo
