I can't reopen this, perhaps because the original branch was deleted. Anyway,
I'm at least willing to discuss and certainly not directly opposed if somebody
wants to open a new PR. Not because Fedora this or that but because I think
symmetry makes sense: if we have a way force sorting one way,
@pmatilai @hroncok @jasontibbitts @Conan-Kudo
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/597#issuecomment-439326683___
ignatenkobrain commented on this pull request.
> (void) rpmlibNeedsFeature(pkg, "TildeInVersions", "4.10.0-1");
+/* check if the package has a dependency with a '^' */
+if (haveCharInDep(pkg, '^'))
+ (void) rpmlibNeedsFeature(pkg, "CaretInVersions", "4.14.0-1");
not sure
pmatilai commented on this pull request.
> (void) rpmlibNeedsFeature(pkg, "TildeInVersions", "4.10.0-1");
+/* check if the package has a dependency with a '^' */
+if (haveCharInDep(pkg, '^'))
+ (void) rpmlibNeedsFeature(pkg, "CaretInVersions", "4.14.0-1");
The version in
1.1^20160101 means 1.1 version (base) and patches which were applied at
that date on top of it.
* 1.1^201601 > 1.1
* 1.1^201601 < 1.1.1
Second case might be fulfilled with tilde separator, but it's not obvious
and doesn't fulfil first case.
Signed-off-by: Igor Gnatenko
You can view, comment
@ffesti @ignatenkobrain Let's have a clearer name for the function, please?
Char does not mean carat to me. :)
EDIT: I'm dumb. This is a generalization of the tilde function.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@ffesti @ignatenkobrain Let's have a clearer name for the function, please?
`Char` does not mean `carat` to me. :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Conan-Kudo approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/597#pullrequestreview-175803053___
Conan-Kudo approved this pull request.
The changes look good, but here's a suggestion for the function name change.
> @@ -228,12 +228,12 @@ static rpmRC processScriptFiles(rpmSpec spec, Package
> pkg)
return rc;
}
-static int haveTildeDep(Package pkg)
+static int haveCharInDep(Package
Like noted in #88, I'm not opposed. Symmetry usually makes sense, and if
there's a way to force sorting one way then why not the other? Especially since
there clearly is a technical case for it too.
@mlschroe , thoughts?
--
You are receiving this because you are subscribed to this thread.
Sounds good to me. ^ is a nice character for this.
haveCharInDep() is not a great name for the function, but meh...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
I'd simply leave the file associations out of this style of dep generation
entirely, it'd be for the cases where the file associations don't make sense
which is quite a common case actually. The %generate-script could take the
subpackage as an optional argument, similarly to other spec
Hi,
Currently my .spec file for my tools build contains python requirement as
```
Requires: python
```
But this seems to sometimes not work on Amazon Linux, where by default `python`
installed is `v2.7.13/14` . This creates problem when trying to install my
package. (even though
it's hard to guess what problem you are hitting. But you can specify `Requires:
(python >= 2.6 with python < 2.7)`
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Can i do something like `Requires: (python >= 2.6 or python <= 2.7)` ?
I need this: check for `python 2.6` or `python 2.7`, use whichever one is
available`
I already tried `Requires: python >= 2.6`, it doesn't seem to work.
If i check `which python`, it shows `/usr/bin/python` and `python
that's not a problem of RPM, that's problem of you not using yum/dnf. Sorry.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
16 matches
Mail list logo
